Enable secure protocol #1240

pull suriyaa wants to merge 2 commits into bitcoin:master from suriyaa:secure-protocol changing 28 files +40 −40
  1. suriyaa commented at 4:17 pm on November 23, 2021: none
    ping @kallewoof, @luke-jr for ACK
  2. suriyaa renamed this:
    Enable secure protocol for all translations
    [WIP] Enable secure protocol for all translations
    on Nov 23, 2021
  3. Enable secure protocol 49b75b59ed
  4. suriyaa force-pushed on Nov 23, 2021
  5. suriyaa renamed this:
    [WIP] Enable secure protocol for all translations
    Enable secure protocol for all translations
    on Nov 23, 2021
  6. suriyaa renamed this:
    Enable secure protocol for all translations
    Enable secure protocol
    on Nov 23, 2021
  7. in bip-0016.mediawiki:43 in 49b75b59ed outdated
    39@@ -40,7 +40,7 @@ The rules for validating these outpoints when relaying transactions or consideri
    40 # Normal validation is done: an initial stack is created from the signatures and {serialized script}, and the hash of the script is computed and validation fails immediately if it does not match the hash in the outpoint.
    41 # {serialized script} is popped off the initial stack, and the transaction is validated again using the popped stack and the deserialized script as the scriptPubKey.
    42 
    43-These new rules should only be applied when validating transactions in blocks with timestamps >= 1333238400 (Apr 1 2012) <ref>[https://github.com/bitcoin/bitcoin/commit/8f188ece3c82c4cf5d52a3363e7643c23169c0ff Remove -bip16 and -paytoscripthashtime command-line arguments]</ref>. There are transactions earlier than 1333238400 in the block chain that fail these new validation rules. <ref>[http://blockexplorer.com/tx/6a26d2ecb67f27d1fa5524763b49029d7106e91e3cc05743073461a719776192 Transaction 6a26d2ecb67f27d1fa5524763b49029d7106e91e3cc05743073461a719776192]</ref>. Older transactions must be validated under the old rules. (see the Backwards Compatibility section for details).
    44+These new rules should only be applied when validating transactions in blocks with timestamps >= 1333238400 (Apr 1 2012) <ref>[https://github.com/bitcoin/bitcoin/commit/8f188ece3c82c4cf5d52a3363e7643c23169c0ff Remove -bip16 and -paytoscripthashtime command-line arguments]</ref>. There are transactions earlier than 1333238400 in the block chain that fail these new validation rules. <ref>[https://blockexplorer.com/tx/6a26d2ecb67f27d1fa5524763b49029d7106e91e3cc05743073461a719776192 Transaction 6a26d2ecb67f27d1fa5524763b49029d7106e91e3cc05743073461a719776192]</ref>. Older transactions must be validated under the old rules. (see the Backwards Compatibility section for details).
    


    katesalazar commented at 9:11 pm on December 11, 2021:
    This is a broken link.

    suriyaa commented at 3:11 pm on December 15, 2021:
    @katesalazar Thanks for the feedback. I fixed the broken links.
  8. katesalazar changes_requested
  9. katesalazar commented at 9:12 pm on December 11, 2021: contributor
    Broken links are replaced with broken links, causing history noise for no benefit.
  10. Fix broken links 4b795029bf
  11. suriyaa commented at 3:14 pm on December 15, 2021: none
    See also related pull request #1250.
  12. luke-jr added the label Proposed BIP modification on Dec 15, 2021
  13. luke-jr commented at 9:23 pm on December 15, 2021: member

    I don’t see the need to replace with https everywhere. It’s not like the links are privacy or security sensitive…

    Also prefer not redirecting blockexplorer.com links to blockchain.com.

    But ultimately the authors of each BIP will have to make the call…

  14. kallewoof commented at 11:05 pm on December 15, 2021: member
    I see this as bloat, personally. I also think we need to keep PRs to per-BIP unless there’s a group of them (e.g. the taproot BIPs).
  15. katesalazar commented at 10:31 am on December 16, 2021: contributor
    In 4b795029bf4e I think there are no broken links left to be fixed.
  16. murchandamus commented at 8:10 pm on April 26, 2024: contributor

    I’m closing this PR as it has multiple merge conflicts and has been inactive for almost three years, the replacement of http with https seems unnecessary, and the broken links appear to have been fixed via archive links or seem to be working again.

    I would suggest that any outstanding issues are addressed with new PRs that focus only on a single document each.

  17. murchandamus closed this on Apr 26, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 05:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me