add BANK Wallet to supported wallets list #749

pull esengulov wants to merge 2 commits into bitcoin:master from esengulov:patch-1 changing 0 files +0 −0
  1. esengulov commented at 10:41 am on January 2, 2019: none
  2. add BANK Wallet to supported wallets list c6c5371d5c
  3. luke-jr commented at 2:59 pm on February 15, 2019: member
  4. luke-jr added the label Proposed BIP modification on Feb 15, 2019
  5. in bip-0044.mediawiki:278 in c6c5371d5c outdated
    274@@ -275,6 +275,7 @@ is required and a pull request to the above file should be created.
    275 * [[https://www.ledgerwallet.com/|Ledger Wallet]] ([[https://github.com/LedgerHQ|source]])
    276 * [[https://21.co/learn/21-lib-wallet/|21 Machine Wallet]] ([[https://github.com/21dotco|source]])
    277 * [[https://trustwalletapp.com/|Trust Wallet]] ([[http://github.com/trustWallet/|source]])
    278+* [[https://horizontalsystems.io/dapps/bank-wallet/ | BANK Wallet]] ([[https://github.com/horizontalsystems/bank-wallet-ios/|iOS Sources ]]) / ([[https://github.com/horizontalsystems/bank-wallet-android/|Android Sources ]])
    


    jonathancross commented at 4:13 pm on May 14, 2019:
    Please remove extra spaces: before closing bracket ], before and after the pipe | – they result in a broken link.

    jonathancross commented at 4:15 pm on May 14, 2019:
    The other wallets in this list use “source” (singular, lowercase). For consistency, please also use “source” rather than “Sources”.
  6. prusnak commented at 9:36 pm on May 14, 2019: contributor
    I would remove all wallets from the BIP. It’s hard to find a wallet which does not use BIP-44 nowadays and obviously, I don’t want to maintain the list of all wallets in BIP-44.
  7. braydonf commented at 10:04 pm on May 14, 2019: none
    @prusnak That has already been updated on the master branch via #770, and this PR now has conflicts, and can likely be closed.
  8. prusnak commented at 9:39 am on May 15, 2019: contributor
    @luke-jr please close
  9. TreyChimi5252 approved
  10. TreyChimi5252 approved
  11. Merge branch 'master' into patch-1 f4c06417d0
  12. luke-jr closed this on Sep 19, 2019

  13. esengulov deleted the branch on Sep 20, 2019

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-28 05:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me