Withdraw BIP151 #772

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2019/03/withdraw_BIP151 changing 2 files +3 −3
  1. jonasschnelli commented at 9:08 pm on March 22, 2019: contributor
    The BIP151 proposal does have some practical downsides and thus a new proposal has been made (https://gist.github.com/jonasschnelli/c530ea8421b8d0e80c51486325587c52)
  2. luke-jr commented at 5:55 am on March 29, 2019: member
    BIP 151 never left Draft status, so why not just revise it?
  3. sipa commented at 6:13 am on March 29, 2019: member
    Given that BIP151 already has an assigned number, I think it would be inadvisable to keep using the same number for a substantially different design.
  4. luke-jr commented at 6:30 am on March 29, 2019: member
    Number assignment is not finalisation. Maybe if there was a production implementation of it, but as a mere draft, I don’t see why. The new one is still “Peer-to-Peer Communication Encryption”, no?
  5. jonasschnelli commented at 8:00 am on March 29, 2019: contributor
    The main reason why this number/proposal should and probably cannot be re-used for a new, heavy incompatible proposal is, that implementations have been made (bcoin, armory). I don’t think they are (no longer) in production but still,… the code is available.
  6. luke-jr commented at 8:16 am on March 29, 2019: member

    I’m not really convinced, but not worth spending time arguing…

    The README needs a style change, though: |- style=“background-color: #ffcfcf”

  7. jonasschnelli force-pushed on Mar 29, 2019
  8. jonasschnelli commented at 9:06 am on March 29, 2019: contributor

    The README needs a style change, though: |- style=“background-color: #ffcfcf”

    Done.

  9. luke-jr commented at 9:48 am on March 29, 2019: member
    … the style change is needed for BIP 151, not BIP 152 ;)
  10. Withdraw BIP151 73d06b4a13
  11. jonasschnelli force-pushed on Mar 29, 2019
  12. jonasschnelli commented at 7:52 pm on March 29, 2019: contributor
    Fixed
  13. luke-jr merged this on Apr 4, 2019
  14. luke-jr closed this on Apr 4, 2019

  15. ysangkok cross-referenced this on Feb 4, 2021 from issue Reject 150 (expired) by ysangkok

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 01:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me