BIP-158: Remove some remaining “extended” mentions #799

pull stevenroose wants to merge 1 commits into bitcoin:master from stevenroose:nit-bip158 changing 1 files +1 −1
  1. stevenroose commented at 9:20 am on July 4, 2019: contributor
    The extended filter type was removed in #687, but some mentions were still present in the document. They can be confusing.
  2. stevenroose commented at 9:21 am on July 4, 2019: contributor
    Please review, @Roasbeef @aakselrod
  3. MarcoFalke commented at 9:26 pm on July 8, 2019: member

    See also:

    • BIP 158: remove old reference to extended filter type #787
  4. stevenroose cross-referenced this on Jul 9, 2019 from issue BIP 158: remove old reference to extended filter type by fjahr
  5. stevenroose commented at 3:37 pm on July 9, 2019: contributor
    This can be closed if #787 also takes out the filter type code usage. I wasn’t aware of that PR, my apologies.
  6. luke-jr added the label Proposed BIP modification on Jul 23, 2019
  7. in bip-0158.mediawiki:325 in 4c133eb7dd outdated
    320@@ -323,7 +321,7 @@ This BIP allocates a new service bit:
    321 |-
    322 | NODE_COMPACT_FILTERS
    323 | style="white-space: nowrap;" | <code>1 << 6</code>
    324-| If enabled, the node MUST respond to all BIP 157 messages for filter types <code>0x00</code> and <code>0x01</code>
    325+| If enabled, the node MUST respond to all BIP 157 messages for filter type <code>0x00</code>
    


    Roasbeef commented at 0:34 am on July 26, 2019:
    If #787 goes in, then we only need this section.
  8. Roasbeef commented at 3:03 am on July 26, 2019: contributor
    Can be rebased now that #787 has landed.
  9. stevenroose force-pushed on Jul 26, 2019
  10. BIP-158: Remove some remaining "extended" mentions 30292b727e
  11. stevenroose commented at 9:36 am on July 26, 2019: contributor
    rebased
  12. MarcoFalke cross-referenced this on Sep 25, 2019 from issue BIP 158: Fix mediawiki syntax typo, Remove remnants of the second filter type by MarcoFalke
  13. Roasbeef commented at 2:23 am on October 25, 2019: contributor
    #845 includes this fix (and others), so I think we can merge that instead.
  14. luke-jr closed this on Oct 25, 2019


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-23 14:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me