Replace elixir bip39 implementation #891

pull aerosol wants to merge 1 commits into bitcoin:master from aerosol:replace-elixir-bip39-implementation changing 1 files +1 −1
  1. aerosol commented at 0:10 am on February 21, 2020: contributor

    Follow up to #883

    Advantages:

    • 100% test coverage + CI set up
    • smaller tests that strictly address properties of the specs
    • documentation
    • vectors.json identical to Trezor’s + tests for seed verification with a passphrase
    • idiomatic code, no compilation warnings, no unnecessary conversions to strings containing binary numbers
    • flexible interface, e.g. works with raw binaries as well as hex-encoded
    • does not output 1.5M of text when running tests
    • does not confuse entropy with a private key
    • no commented out code
    • descriptive commit log @prusnak let me know if you’d like me to squash the commits
  2. prusnak commented at 10:31 am on February 21, 2020: contributor
    ACK if the commits are squashed
  3. Update BIP39 Elixir implementation 1a42bb3450
  4. aerosol force-pushed on Feb 21, 2020
  5. aerosol commented at 10:57 am on February 21, 2020: contributor
    @prusnak done, thanks
  6. aerosol commented at 1:04 pm on February 25, 2020: contributor
    @prusnak let me know if this looks good please. Cheers.
  7. prusnak commented at 1:13 pm on February 25, 2020: contributor
    ack
  8. aerosol commented at 10:03 am on February 26, 2020: contributor
    Could you merge then? Thanks
  9. prusnak commented at 12:54 pm on February 26, 2020: contributor
    I can’t. I am not an owner/maintainer of this repo
  10. aerosol commented at 3:30 pm on February 26, 2020: contributor
    @luke-jr please have a look, thank you
  11. luke-jr merged this on Feb 28, 2020
  12. luke-jr closed this on Feb 28, 2020

  13. aerosol deleted the branch on Mar 17, 2020


aerosol prusnak


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-24 06:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me