bip-325: correct placement of challenge #1005

pull kallewoof wants to merge 1 commits into bitcoin:master from kallewoof:202010-signet-sigscript changing 1 files +3 −1

kallewoof commented at 9:56 PM on October 5, 2020: member

In #1003 (review) (where I adopt the approach here), it is pointed out that the message signature going into the scriptPubKey of the spending transaction is weird.

It should go into the scriptSig and/or scriptWitness, and the scriptPubKey for the spending tx is OP_RETURN.
kallewoof commented at 9:57 PM on October 5, 2020: member

Ping @ajtowns.
in bip-0325.mediawiki:64 in ccbb7bfdfe outdated
```
  59 | @@ -60,8 +60,10 @@ The "to_sign" transaction is:
  60 |      vin[0].prevout.hash = to_spend.txid
  61 |      vin[0].prevout.n = 0
  62 |      vin[0].nSequence = 0
  63 | +    vin[0].sigScript = [ signet_challenge first data push, if any ]
  64 | +    vin[0].scriptWitness = [ signet_challenge second data push, if any ]
```
ajtowns commented at 1:34 AM on October 6, 2020:

These are from the signet solution, not the signet challenge, and there's only a single data push of the serialization of the scriptSig and and scriptWitness concatenated.

kallewoof commented at 1:43 AM on October 6, 2020:

Doh, I meant the signet solution.

There's a single push, of the 1-2 pushes of sigScript followed by optional scriptWitness, right? That's what I'm referring to.

kallewoof commented at 6:09 AM on October 6, 2020:

Gah, I meant the solution, not challenge.
ajtowns commented at 1:35 AM on October 6, 2020: contributor

Hmm, I guess that was either a copy and paste error, or leftover from the previous approach?
kallewoof force-pushed on Oct 6, 2020
bip-325: correct placement of challenge bb989a69e0

in bip-0325.mediawiki:64 in fd50eeaf4f outdated

  59 | @@ -60,8 +60,10 @@ The "to_sign" transaction is:
  60 |      vin[0].prevout.hash = to_spend.txid
  61 |      vin[0].prevout.n = 0
  62 |      vin[0].nSequence = 0
  63 | +    vin[0].sigScript = [ signet_solution first data push, if any ]
  64 | +    vin[0].scriptWitness = [ signet_solution second data push, if any ]

MarcoFalke commented at 6:31 AM on October 6, 2020:

    vin[0].scriptWitness = [ signet_solution scriptWitness (y bytes), if any ]

Maybe refer to it with the length to avoid the "data push" confusion?

kallewoof commented at 6:34 AM on October 6, 2020:

Good idea

kallewoof force-pushed on Oct 6, 2020
ajtowns commented at 2:33 PM on October 7, 2020: contributor

Looks good to me
kallewoof commented at 2:43 AM on October 8, 2020: member

Ping @luke-jr
luke-jr merged this on Oct 8, 2020
luke-jr closed this on Oct 8, 2020

Contributors

kallewoof

ajtowns

MarcoFalke

Linked (view graph)

#1003 BIP-322: switch to using tx based approach