BIP62: Reorder rules and clarify #102

pull sipa wants to merge 1 commits into bitcoin:master from sipa:bip62up2 changing 1 files +40 −26

sipa commented at 9:22 PM on September 7, 2014: member

No description provided.
sipa force-pushed on Sep 7, 2014
sipa force-pushed on Sep 7, 2014
sipa force-pushed on Sep 7, 2014
sipa force-pushed on Sep 7, 2014
sipa force-pushed on Sep 7, 2014
sipa force-pushed on Sep 7, 2014
sipa force-pushed on Sep 7, 2014
sipa force-pushed on Sep 7, 2014
sipa force-pushed on Sep 7, 2014
sipa force-pushed on Sep 7, 2014
sipa cross-referenced this on Sep 7, 2014 from issue Restructure and make rules 2 and 4 unconditional by sipa
jgarzik commented at 4:49 PM on September 12, 2014: contributor

ACK

in bip-0062.mediawiki:None in 3a62d6375b outdated

  98 | +* OP_PUSHDATA4 can never be used, as pushes over 520 bytes are not allowed, and those below can be done using other operators.
  99 | +* Any other operation is not considered to be a push.
 100 | +
 101 | +====Numbers====
 102 | +
 103 | +The native data type of stack elements is byte arrays, but some operations interpret arguments as integers. The used encoding is little endian with an explicit sign bit (the highest bit of the last byte). The shortest encodings for numbers are (with the range bounderies encodings given in hex between ()).

laanwj commented at 7:34 AM on September 13, 2014:

s/bounderies/boundaries

sipa commented at 5:27 PM on September 13, 2014:

Fixed.

sipa force-pushed on Sep 13, 2014
sipa force-pushed on Sep 13, 2014
gmaxwell commented at 5:04 PM on September 21, 2014: contributor

ACK the reorder, because it's good forward progress... but rule 1 is ambiguous. It can be read as if a hybrid pubkey in a txout is not permitted.

The rule 1 for any input in block v3 may make some existing spendable (and currently IsStandard) txouts forever unspendable, because of P2SH we can't even know in advance which ones it would slay. Are we really okay with that?
sipa commented at 4:23 AM on September 22, 2014: member

The intention was indeed to disallow hybrid pubkeys, but you raise a very good point. I don't think hybrid keys are actually used, but there are many cases of invalid public keys inside multisig which would also potentially become invalid due to this rule - especially as the rule is only applied on spending, this could potentially make actual coins unspendable.

Too bad, but that needs fixing.
BIP62: Reorder rules and clarify 9625a83f70
sipa force-pushed on Sep 22, 2014
sipa commented at 7:39 PM on September 22, 2014: member

I removed the language about public keys again.
gmaxwell commented at 7:47 PM on September 22, 2014: contributor

ACK
gmaxwell referenced this in commit b3925792de on Sep 27, 2014
gmaxwell merged this on Sep 27, 2014
gmaxwell closed this on Sep 27, 2014

Contributors

Linked (view graph)

#90 Restructure and make rules 2 and 4 unconditional