BIP34 encoding clarification #1039

pull Greg-Griffith wants to merge 1 commits into bitcoin:master from Greg-Griffith:bip34-encoding-clarification changing 1 files +1 −1

Greg-Griffith commented at 8:22 PM on November 18, 2020: contributor

Non minimal encodings are rejected by the bitcoin-core client because it only checks against a specific encoding. Link for reference: https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L3503

For example: Height 16512 has two encodings which should be valid according to the spec. 03804000 and 028040. However, the prior would always be rejected due to the implementation of the BIP34 height check.

BIP34 specifies it requires minimal encoding.

Non minimal encodings are rejected by the bitcoin-core client because it 
only checks against a specific encoding

08844fd6ef

luke-jr added the label Proposed BIP modification on Feb 3, 2021
luke-jr commented at 10:08 PM on February 3, 2021: member

@gavinandresen
gavinandresen commented at 10:18 PM on February 3, 2021: contributor

ACK
luke-jr merged this on Feb 4, 2021
luke-jr closed this on Feb 4, 2021
sickpig referenced this in commit b6056a5a4b on Feb 16, 2021

Contributors

Labels