BIP173: segwit address witness version is one 5-bit char not one byte #1051

pull pinheadmz wants to merge 1 commits into bitcoin:master from pinheadmz:bip173-witnessversion1 changing 1 files +1 −1

pinheadmz commented at 3:13 PM on January 5, 2021: member

When describing the segwit address, bc1q... for example - the q represents witness version 0 but it is not one entire byte as the BIP currently describes it, it is one bech32 character which only represents 5 bits.

(unless the intention is to describe the byte in terms of how ASCII characters occupy one byte?)
BIP173: segwit address witness version is one 5-bit char not one byte e1e7b77c02
michaelfolkson commented at 4:47 PM on January 5, 2021: contributor

ACK. Nice spot.
luke-jr commented at 10:18 PM on February 3, 2021: member

@sipa @gmaxwell
luke-jr added the label Proposed BIP modification on Feb 3, 2021
sipa commented at 2:08 AM on February 4, 2021: member

ACK e1e7b77c027b3d40d07d306cc75c2b5859c91db2
gmaxwell commented at 8:20 PM on April 25, 2021: contributor

ACK e1e7b77c027b3d40d07d306cc75c2b5859c91db2
kallewoof merged this on Jun 13, 2021
kallewoof closed this on Jun 13, 2021

Contributors

Labels