Amend BIP72 by an "h" parameter, which contains a hash of the… #106

pull schildbach wants to merge 1 commits into bitcoin:master from schildbach:bip72-hash changing 1 files +18 −6

schildbach commented at 9:01 AM on September 12, 2014: contributor

…PaymentRequest message that is fetched via the "r" parameter.

The hash is meant to link the trust anchor (e.g. the QR code) to the payment request message in a secure way. This will solve the problem several apps are comparing address+amount fields as a workaround instead, preventing some advanced BIP70 usecases. When these apps read a matching hash, they need not compare any of the other fields.

Thanks to Julian Haight for helping with the standard.
Amend BIP72 by an "h" parameter, which contains a hash of the PaymentRequest message that is fetched via the "r" parameter. c2298e90d5
laanwj commented at 9:22 AM on September 12, 2014: member

Sounds like a good idea to me.

However various people have protested against non-trivial changes to current BIPs in the past, especially those in common use. Instead of 'amend' BIP72 it may be better to add a new BIP that describes this.

Also this needs a discussion post on the mailing list.
schildbach commented at 9:43 AM on September 12, 2014: contributor

Thanks for reminding me on the discussion post. I have posted now.
jgarzik commented at 12:31 PM on September 12, 2014: contributor

Procedural: We don't patch deployed BIPs.

A new BIP is needed.
laanwj commented at 12:47 PM on September 12, 2014: member

@jgarzik I had already said that.
schildbach commented at 12:47 PM on September 12, 2014: contributor

@jgarzik It was never finished, so I thought its a better idea to "patch" it. But I'm ok with moving to a new BIP number as well if that makes the majority happy.
schildbach cross-referenced this on Sep 12, 2014 from issue BIP 72 Support by haight6716
gavinandresen commented at 7:36 PM on October 6, 2014: contributor

New BIP number.
laanwj commented at 7:58 AM on October 15, 2014: member

How can we move this forward? @schildbach Have you proposed this as a new BIP yet?
AndySchroder commented at 3:00 PM on October 15, 2014: none

A new BIP has been drafted up that includes this improvement as well as several others. As soon as @schildbach and I finish fine tuning a few sentances, it will be announced for feedback/review.
laanwj commented at 3:03 PM on October 15, 2014: member

Thanks for letting me know @AndySchroder I'll close this issue then.
laanwj closed this on Oct 15, 2014
snapfractalpop cross-referenced this on Mar 21, 2018 from issue Status on BIP70 support? by snapfractalpop

Contributors