No description provided.
Finalize BIP-47 #1068
pull justusranvier wants to merge 2 commits into bitcoin:master from OpenBitcoinPrivacyProject:bip47 changing 1 files +10 −4-
justusranvier commented at 3:30 PM on February 15, 2021: contributor
-
5ec9df085e
BIP-0047: Adjust text to match test vectors
The original implementation of BIP-47 in Samourai Wallet reversed the parameters in the calculation of the HMAC-SHA512 step of notification transaction blinding. This change adjusts the text to match the as-implementend behavior in deployed BIP-47 wallets and the test vectors.
-
Finalize BIP-47 bc069fa050
-
ghost commented at 3:17 AM on March 3, 2021: none
Concept ACK
Status should be changed to
finalfromdraftHowever I am not sure about the things added in https://github.com/bitcoin/bips/pull/1068/commits/bc069fa050fb9816746c9e13b34d9d13a7d89562 and the reasons for maintaining v3 in a separate repository:
future developments of the reusable payment codes specification will not be distributed via the BIP process.
-
gmaxwell commented at 9:26 PM on April 25, 2021: contributor
This seems fine to me, including the redirection.
-
murchandamus commented at 6:04 PM on April 24, 2024: contributor
Since BIP47 is implemented by at least three software projects and this is a modification of the BIP author of his own BIP, this seems ready to merge to me.
- murchandamus merged this on Apr 24, 2024
- murchandamus closed this on Apr 24, 2024
Contributors