BIP 341: Specify Speedy Trial activation parameters #1081

achow101 commented at 10:24 PM on March 8, 2021: member

Specifies activation parameters for BIP 341 using the Speedy Trial activation proposal discussed on the bitcoin-dev mailing list.

Testnet parameters were not discussed so I just chose block heights that corresponded to a start time of 2021/04/18 with 3 retarget periods of activation time and an additional 3 retarget periods for the minimum activation height.

Requires #1080 as it uses the minimum_activation_height specified there.

achow101 cross-referenced this on Mar 8, 2021 from issue BIP 341: Add Speedy Trial activation parameters by achow101

michaelfolkson commented at 12:43 PM on March 14, 2021: contributor

This includes (mistakenly I think) the commit making changes to BIP 8. This PR should only be making changes to BIP 341.

in bip-0341.mediawiki:299 in 57f7ea403d outdated

 293 | @@ -294,7 +294,15 @@ Examples of preimage for sighashing for each of the sighash modes.
 294 |  
 295 |  == Deployment ==
 296 |  
 297 | -TODO
 298 | +There may be multiple deployment attempts of this BIP.
 299 | +
 300 | +The first deployment wil use BIP 8 with the name "taproot", using bit 2, and a lockinontimeout of false.

michaelfolkson commented at 12:44 PM on March 14, 2021:

nit s/wil/will

achow101 commented at 5:56 PM on March 14, 2021:

Done

in bip-0341.mediawiki:301 in 57f7ea403d outdated

 293 | @@ -294,7 +294,15 @@ Examples of preimage for sighashing for each of the sighash modes.
 294 |  
 295 |  == Deployment ==
 296 |  
 297 | -TODO
 298 | +There may be multiple deployment attempts of this BIP.
 299 | +
 300 | +The first deployment wil use BIP 8 with the name "taproot", using bit 2, and a lockinontimeout of false.
 301 | +
 302 | +For Bitcoin mainnet, the BIP 8 startheight will be 681408, the timeoutheight will be 695520, the minimum_activation_height will be 709632, and the activation threshold will be 1815 out of 2016 blocks.

michaelfolkson commented at 12:47 PM on March 14, 2021:

Perhaps follow "1815 out of 2016 blocks" with "(90 percent)" to make it clear a threshold of 90 percent is set.

achow101 commented at 5:56 PM on March 14, 2021:

Done

in bip-0341.mediawiki:303 in 57f7ea403d outdated

 299 | +
 300 | +The first deployment wil use BIP 8 with the name "taproot", using bit 2, and a lockinontimeout of false.
 301 | +
 302 | +For Bitcoin mainnet, the BIP 8 startheight will be 681408, the timeoutheight will be 695520, the minimum_activation_height will be 709632, and the activation threshold will be 1815 out of 2016 blocks.
 303 | +
 304 | +For Bitcoin testnet, the BIP 8 startheight will be 1945440, The timeoutheight will be 1951488, the minimum_activation_height will be 1957536, and the activation threshold will be 1512 out of 2016 blocks.

michaelfolkson commented at 12:48 PM on March 14, 2021:

Perhaps follow "1512 out of 2016 blocks" with "(75 percent)" to make it clear a threshold of 75 percent is set.

achow101 commented at 5:56 PM on March 14, 2021:

Done

michaelfolkson commented at 12:48 PM on March 14, 2021: contributor

A few more nits.

achow101 force-pushed on Mar 14, 2021

achow101 commented at 5:56 PM on March 14, 2021: member

This includes (mistakenly I think) the commit making changes to BIP 8. This PR should only be making changes to BIP 341.

It is not mistaken. This PR requires BIP 8 to discuss the minimum activation height.

luke-jr added the label Proposed BIP modification on Mar 15, 2021

Sjors commented at 3:09 PM on March 20, 2021: member

Concept ACK. Can you add estimated dates next to the heights? I'd like to see https://github.com/bitcoin/bitcoin/pull/21392 merged and backported before committing to specific heights.

Ideally I'd also like to see another client implement the speedy trial mechanism.

btcd is making some progress towards BIP 8 support, though no speedy trial yet: https://github.com/btcsuite/btcd/pull/1700. They also have no taproot implementation (only Schnorr WIP in https://github.com/btcsuite/btcd/pull/1667), but at least they would be able to detect a new softfork activated.
bcoin has an old draft PR https://github.com/bcoin-org/bcoin/pull/948 to implement Taproot, but no BIP 8
libbitcoin appears to have Taproot work in progress: https://github.com/libbitcoin/libbitcoin-system/issues/1177 but no BIP 8 yet

achow101 force-pushed on Mar 20, 2021

achow101 commented at 5:44 PM on March 20, 2021: member

Added approximate dates

in bip-0341.mediawiki:301 in f0ea9c25ee outdated

 293 | @@ -294,7 +294,15 @@ Examples of preimage for sighashing for each of the sighash modes.
 294 |  
 295 |  == Deployment ==
 296 |  
 297 | -TODO
 298 | +There may be multiple deployment attempts of this BIP.
 299 | +
 300 | +The first deployment will use BIP 8 with the name "taproot", using bit 2, and a lockinontimeout of false.
 301 | +
 302 | +For Bitcoin mainnet, the BIP 8 startheight will be 681408 (approximately May 1st 2021), the timeoutheight will be 695520 (approximately August 6th 2021), the minimum_activation_height will be 709632 (approximately Novermber 12th 2021), and the activation threshold will be 1815 out of 2016 blocks (90%).

flack commented at 7:02 PM on March 20, 2021:

For Bitcoin mainnet, the BIP 8 startheight will be 681408 (approximately May 1st 2021), the timeoutheight will be 695520 (approximately August 6th 2021), the minimum_activation_height will be 709632 (approximately November 12th 2021), and the activation threshold will be 1815 out of 2016 blocks (90%).

achow101 commented at 7:07 PM on March 20, 2021:

Oops, fixed.

achow101 force-pushed on Mar 20, 2021

benthecarman commented at 4:10 PM on March 22, 2021: contributor

ACK 3704017f7ba4e0c152c805d6af9969be48d30cdd

BIP341/342: document current deployment status a516c135ab

in bip-0341.mediawiki:303 in 3704017f7b outdated

 299 | +
 300 | +The first deployment will use BIP 8 with the name "taproot", using bit 2, and a lockinontimeout of false.
 301 | +
 302 | +For Bitcoin mainnet, the BIP 8 startheight will be 681408 (approximately May 1st 2021), the timeoutheight will be 695520 (approximately August 6th 2021), the minimum_activation_height will be 709632 (approximately November 12th 2021), and the activation threshold will be 1815 out of 2016 blocks (90%).
 303 | +
 304 | +For Bitcoin testnet, the BIP 8 startheight will be 1945440 (approximately April 20th 2021), The timeoutheight will be 1951488 (approximately June 1st 2021), the minimum_activation_height will be 1957536 (approximately July 13th 2021), and the activation threshold will be 1512 out of 2016 blocks (75%).

ajtowns commented at 11:16 AM on March 24, 2021:

The entire testnet range from block 1945440 to 1957536 was mined today, with no signalling on bit 2 (actually no signalling except on the bip 320 reserved bits).

Probably doesn't make sense to use future heights for testnet.

achow101 commented at 3:10 AM on March 25, 2021:

Ah that's unfortunate. Maybe it should just be always active? Gonna try seeing if I can sync a testnet node with that.

ajtowns commented at 3:24 AM on March 25, 2021:

I was thinking just add activation rules for testnet after it's active on mainnet, maybe even after it's buried on mainnet?

achow101 commented at 3:56 AM on March 25, 2021:

ngl feels like we should abandon testnet3 really.

michaelfolkson commented at 3:52 PM on March 25, 2021:

Agree with AJ's suggestion to activate on testnet once active on mainnet given Taproot is available for testing on signet. The fewer heights we have to keep adjusting the better.

achow101 commented at 8:36 PM on March 25, 2021:

Dropped these testnet params and marked it as TBD.

achow101 force-pushed on Mar 25, 2021

ajtowns commented at 8:39 PM on March 25, 2021: contributor

This misses activating BIP342 -- suggest rebasing on #1091 to fix that.

achow101 force-pushed on Mar 25, 2021

achow101 commented at 8:41 PM on March 25, 2021: member

Rebased onto #1091

in bip-0341.mediawiki:307 in 5111f86820 outdated

 303 | +
 304 | +The first deployment will use BIP 8 with the name "taproot", using bit 2, and a lockinontimeout of false.
 305 | +
 306 | +For Bitcoin mainnet, the BIP 8 startheight will be 681408 (approximately May 1st 2021), the timeoutheight will be 695520 (approximately August 6th 2021), the minimum_activation_height will be 709632 (approximately November 12th 2021), and the activation threshold will be 1815 out of 2016 blocks (90%).
 307 | +
 308 | +For Bitcoin testnet, TBD.

Sjors commented at 9:32 AM on March 26, 2021:

Maybe elaborate here:

For Bitcoin testnet, TBD. Due to the difficulty reset, the pace of testnet block generation is unpredictable. This makes height based activation impractical.

michaelfolkson commented at 11:39 AM on March 26, 2021:

Or alternatively:

"For Bitcoin testnet, Taproot will be activated if and when Taproot is active on mainnet. Taproot is already active on signet for testing and experimentation purposes."

ajtowns commented at 4:07 PM on March 30, 2021:

I think startheight of 1967616 (recently passed) and timeoutheight 2169216 (100*2016 ~= 200k blocks in the future) and minimum_activation_height of 0 could work -- segwit was activated on testnet well prior the code even being merged into core, so that's precedent for not worrying about wide deployment/enforcement for testnet, and 200k blocks is likely only about a year of mining (going by a total of ~1.96M blocks over testnet's ~9 years) and probably less; but also almost certainly no worse than 4 years -- and presumably it will take more than 4 years before we want to reuse the signalling bit.

achow101 commented at 4:53 PM on March 30, 2021:

Added these proposed heights.

ajtowns cross-referenced this on Mar 28, 2021 from issue Implement BIP 8 based Speedy Trial activation by achow101

Add taproot activation parameters 4c79a1844a

achow101 force-pushed on Mar 30, 2021

ajtowns cross-referenced this on Apr 13, 2021 from issue BIP341: speedy trial activation parameters by ajtowns

Rspigler commented at 5:06 AM on April 15, 2021: contributor

Should this be closed now?

achow101 closed this on Apr 15, 2021