BIP32 does not work with uncompressed public key; thus, all BIP32-related fields must explicitly require that the public key for the map key value must be serialized in compressed format
PSBT: Require compressed keys for BIP32 key fields #1100
pull dr-orlovsky wants to merge 1 commits into bitcoin:master from dr-orlovsky:patch-7 changing 1 files +4 −4-
dr-orlovsky commented at 11:55 AM on April 12, 2021: contributor
-
f5ec07a6c8
PSBT: Require compressed keys for BIP32 key fields
BIP32 does not work with uncompressed public key; thus, all BIP32-related fields must explicitly require that the public key for the map key value must be serialized in compressed format
-
achow101 commented at 4:26 PM on April 13, 2021: member
I'm actually not sure if that is strictly true. While xpubs are serialized with the compressed pubkey and BIP 32 uses the compressed pubkey in derivation, there is no specific mention of the compressed-ness of the derived key for actual use. Compressed keys are used as a convention, but I don't think they are required by BIP 32. Pubkeys can be easily un/compressed.
-
dr-orlovsky commented at 4:33 PM on April 13, 2021: contributor
If we clearly see use of uncompressed keys as a bad practice, why we should not just update both standards specifying that non-compressed keys will be non-standard application for both BIP32 and PSBT?
-
achow101 commented at 4:44 PM on April 13, 2021: member
Note that there are some applications which use BIP 32 and produce uncompressed pubkeys. The one that comes to mind is Ledger devices.
-
dr-orlovsky commented at 4:00 PM on April 14, 2021: contributor
They may continue doing so, but as a non-standard behavior. The idea of being "Standard" is about what devs will expect from API by default. It does not limit devs from what they can do in addition to that, but distinguishes recommended behavior / good practices.
- luke-jr added the label Proposed BIP modification on Apr 22, 2021
- sanket1729 referenced this in commit e4d5039a86 on Jan 11, 2022
-
murchandamus commented at 7:37 PM on April 26, 2024: contributor
@dr-orlovsky, @achow101: What’s the status on this pull request?
-
achow101 commented at 7:49 PM on April 26, 2024: member
It's been 3 years, so I'm going to go ahead and NACK this for the reasons previously stated.
- murchandamus closed this on Apr 26, 2024
Contributors