bip174: link to 'compact size' definition, document version 0 handling of > 0xFD #1115

pull Sjors wants to merge 2 commits into bitcoin:master from Sjors:2021/04/compact_size changing 1 files +5 −2
  1. Sjors commented at 11:14 AM on April 30, 2021: member

    No description provided.

  2. Sjors commented at 11:14 AM on April 30, 2021: member

    cc @achow101

  3. Sjors renamed this:
    bip174: link to 'compact size' definition
    bip174: link to 'compact size' definition and constrain to < 0xFD
    on Apr 30, 2021
  4. Sjors force-pushed on Apr 30, 2021
  5. Sjors renamed this:
    bip174: link to 'compact size' definition and constrain to < 0xFD
    bip174: link to 'compact size' definition, constrain version 0 to < 0xFD
    on Apr 30, 2021
  6. apoelstra commented at 3:03 PM on June 9, 2021: contributor

    concept ack

  7. luke-jr added the label Proposed BIP modification on Jul 2, 2021
  8. in bip-0174.mediawiki:732 in d04afdb4f9 outdated 
     728 | @@ -729,6 +729,8 @@ If an updater is updating a PSBT and needs to add a field that is only available
 729 |  New fields should first be proposed on the bitcoin-dev mailing list.
 730 |  If a field requires significatn description as to its usage, it should be accompanied by a separate BIP.
 731 |  The field must be added to the field listing tables in the Specification section.
 732 | +New fields with type 0xFD or higher must be added to PSBT version 2 or newer,
    achow101 commented at 10:46 PM on December 17, 2021:

    I don't think this restriction is necessary. Old parsers will regard such fields as unknown anyways, and with the length before the type, no data will be missed.

    Sjors commented at 3:39 PM on January 12, 2022:

    I rephrased it to explain why it's safe.

  9. bip174: link to 'compact size' definition dc034af961
  10. Sjors force-pushed on Jan 12, 2022
  11. bip174: document PSBT 0 handling of type > 0xFD 6366f8ebcb
  12. Sjors force-pushed on Jan 12, 2022
  13. Sjors renamed this:
    bip174: link to 'compact size' definition, constrain version 0 to < 0xFD
    bip174: link to 'compact size' definition, document version 0 handling of > 0xFD
    on Jan 12, 2022
  14. achow101 commented at 6:58 PM on January 12, 2022: member

    ACK 6366f8ebcbab1bc5e59325bf8a00ed96065bd671

  15. luke-jr merged this on Jan 15, 2022
  16. luke-jr closed this on Jan 15, 2022
  17. Sjors deleted the branch on Jan 16, 2022
Contributors
Sjorsapoelstraachow101
Labels
Proposed BIP modification
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 11:10 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me