Opening for bikeshedding here before mirroring the code changes.
Some folks found StandardTemplateHash being a consensus definition and not a policy definition confusing.
This PR attempts at unambiguous names. More verbose than I like, but it's readable at least.
Bikeshed now or forever hold your peace :laughing:
I came here to say: The term "standard" is already a confusing and somewhat ambiguous (because it is customizable and not universal) term in mempool policy, and I hope it doesn't seem like bikeshedding to recommend not overloading it further. For instance, if we were to be calling IsStandard(scriptPubkey, TxoutType::TX_STANDARDTEMPLATE) to determine if an output was standard, but then a tx with a nonstandard template can still be a standard output type, it'll just be extremely confusing.
Anyway, Concept ACK, this seems fine, or you give them version numbers or something.
great --> I think that the best "future" path would be something like where a n+32 byte value has the first n bytes interpreted as a sighash program, so Default is the thing that happen w/o a program?
(as opposed to version numbers)
Dropping WIP; mergeable I think (@kallewoof)
Remnants of at least one SCRIPT_VERIFY_STANDARD_TEMPLATE in there, FYI. I think you meant to change that too.
@JeremyRubin Shall we get this merged?
ok ready to go