BIP118: Key version should be 0x01 #1141

pull sanket1729 wants to merge 1 commits into bitcoin:master from sanket1729:patch-3 changing 1 files +2 −2

sanket1729 commented at 8:29 AM on July 9, 2021: contributor

The key version should be 1 unless I am misunderstanding something.
BIP118: key version should be 0x01 f62639ab52
kallewoof commented at 11:38 AM on July 12, 2021: member

In all cases, key_version is set to the constant value 0x01 instead of 0x00.[6]

According to the above quote, I agree. Ping @ajtowns
ajtowns commented at 12:07 PM on July 12, 2021: contributor

Sounds right to me.

ACK f62639ab52794fe3b99d4a1c10e8ec4daff938d4
kallewoof merged this on Jul 12, 2021
kallewoof closed this on Jul 12, 2021

Contributors