BIP 0009: Remove transparent background from figure. #1184

1. 
   katesalazar commented at 7:26 pm on September 17, 2021: contributor

   Dear champion, authors, community:

   A copy of the revision message follows:

   Remove transparent background from figure.

   Before this change, the figure presented black text on transparent background, which might be unconvenient when using a browser able to pass a dark theme preference to some environments where this document is published, currently notably GitHub. A white background could help a better visualization compromise. White background on the figure is the single purpose of this revision.

   This PNG was compiled using:

   dot -Tpng states.gv -o states.png
   

   TL;DR: I have some visualization problems on dark theme, and this fixes it for me.

   TS;DR: Please ask for anything requiring explanation, screenshots showing the problem, visualization changes… anything you need.

   Thank you.

   Cheers,

2. 
   katesalazar commented at 6:23 am on September 18, 2021: contributor

   Must fixup (squash) cdeec7d23ebed4290b651fec12dd3f05b878dd63 in 6e56466e934a82435d54e9a2b5dab70827404520 before merging, if that were to be the case. Set draft.
3. katesalazar marked this as a draft on Sep 18, 2021
4. katesalazar renamed this:
   Remove transparent background from figure.
   BIP 0009: Remove transparent background from figure.
   on Sep 21, 2021
5. Remove transparent background from figure.

   Before this change, the figure presented black text on transparent
   background, which might be unconvenient when using a browser able to
   pass a dark theme preference to some environments where this document
   is published, currently notably GitHub. A white background could help
   a better visualization compromise. White background on the figure is
   the single purpose of this revision.
   
   This PNG was compiled using:
   
       dot -Tpng states.gv -o states.png

   497ad1c81a
6. katesalazar force-pushed on Nov 16, 2021
7. katesalazar marked this as ready for review on Nov 16, 2021
8. luke-jr added the label Proposed BIP modification on Dec 15, 2021
9. 
   luke-jr commented at 9:59 pm on December 15, 2021: member

   Personally, I like the older style better…
10. 
    katesalazar commented at 5:04 pm on April 24, 2024: contributor

    I encourage anyone to solve the issue alternatively on their own applying the same approach as in #1193
11. murchandamus assigned sipa on Apr 29, 2024
12. 
    murchandamus commented at 8:59 pm on April 30, 2024: contributor

    I have verified that the content of the graph is unchanged except for the new style and background color.

    ACK 497ad1c81a8d7e882c86ffe780db5b01db66d686

13. 
    jonatack commented at 9:14 pm on April 30, 2024: contributor

    ACK, content is the same (with stylistic changes). Tested with GitHub in dark mode with the Dark Reader browser plug-in both off and on as well.
14. jonatack merged this on Apr 30, 2024
15. jonatack closed this on Apr 30, 2024

    ---

Contributors
katesalazar luke-jr murchandamus jonatack

Labels
Proposed BIP modification