Using an absolute path for the figure, instead of a relative path, could help figure presentation on the bitcoin.it wiki, while not affecting presentation on GitHub.
BIP 0001: Absolute path for figure. #1187
pull katesalazar wants to merge 1 commits into bitcoin:master from katesalazar:20210921 changing 1 files +3 −1-
katesalazar commented at 4:49 PM on September 21, 2021: contributor
-
katesalazar commented at 4:50 PM on September 21, 2021: contributor
Other BIPs are affected of this, but I wouldn't go through everything before receiving positive feedback.
- katesalazar marked this as a draft on Sep 21, 2021
-
katesalazar commented at 5:13 PM on September 21, 2021: contributor
I opened this PR before fully realizing this can't be made without transforming the source a little bit at some point.
I personally prefer considering one common source and different translators for different media, but I don't know if you maybe prefer translating from valid source for one medium to valid source for other medium (or if you already have some pipeline wired in).
-
katesalazar commented at 5:19 PM on September 21, 2021: contributor
-
daaaed079b
BIP 0001: Absolute path for figure.
Using an absolute path for the figure, instead of a relative path, could help figure presentation on [the bitcoin.it wiki][0], while not affecting presentation on GitHub. [0]: https://en.bitcoin.it/wiki/BIP_0001
- katesalazar force-pushed on Nov 16, 2021
- katesalazar marked this as ready for review on Nov 16, 2021
-
luke-jr commented at 9:57 PM on December 15, 2021: member
I don't see any reason to do this...?
-
katesalazar commented at 7:58 AM on December 16, 2021: contributor
On Wed, Dec 15, 2021 at 10:57 PM Luke Dashjr @.***> wrote:
I don't see any reason to do this...?
Maybe bitcoin.it is a third party here, and I didn't know that...
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bips/pull/1187#issuecomment-995245208, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4W4JHQLEX7ZN2YBB4PTUREFM5ANCNFSM5EO6J2KQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
-
jonatack commented at 2:56 PM on April 24, 2024: contributor
@katesalazar There doesn't seem to be much support for this change. Are you still working on this PR, and if not, would you consider closing it?
-
katesalazar commented at 4:43 PM on April 24, 2024: contributor
proper and well timed
- katesalazar closed this on Apr 24, 2024
-
jonatack commented at 5:52 PM on April 24, 2024: contributor
Thank you @katesalazar.
Contributors