BIP 0002: Remove transparent background from figure #1192

1. 
   katesalazar commented at 12:37 pm on September 26, 2021: contributor

   This is basically the same as #1184, but there transparent background hampers reading text much more than here hampers seeing the node relationships.
2. Remove transparent background from figure

   This increases contrast when reading on GitHub, if GitHub is switched
   to dark theme.

   801768a5d0
3. katesalazar cross-referenced this on Sep 26, 2021 from issue BIP 0174: Remove transparent background from figures by katesalazar
4. katesalazar cross-referenced this on Sep 26, 2021 from issue BIP 0144: Remove transparent background from figure by katesalazar
5. katesalazar cross-referenced this on Sep 26, 2021 from issue BIP 0156: Remove transparent background from figures. by katesalazar
6. 
   luke-jr commented at 10:50 pm on November 4, 2021: member

   Behind the text, ok, but not the background itself please.
7. luke-jr added the label Proposed BIP modification on Nov 4, 2021
8. 
   katesalazar commented at 9:14 pm on November 5, 2021: contributor

   I would say… something has changed in GitHub dark theme and the contrast is now much better than when this was submitted.

   But I still think that is more convenient a white background in the figure than having connection lines be set to some grey finely tuned to not one but two third party presentation styles, GitHub light and GitHub dark.

   I get that being able to read this BIP here is no more than a byproduct of reading this at the wiki (or any infrastructure under larger control than this), but still. It could be nice that the picture does not causes problems when viewed from GitHub.

9. 
   luke-jr commented at 11:11 pm on November 5, 2021: member

   Maybe a white outline between black and transparency? Not sure how to get that kind of rendering tho
10. 
    katesalazar commented at 6:06 am on November 6, 2021: contributor

    Very good idea. I can and will do that.
11. Add transparent background caf76014f4
12. Draw the rest of the chart fb3a4bc883
13. 
    katesalazar commented at 3:33 pm on November 6, 2021: contributor

    Nailed it.
14. Remove superflous box 0b3a7d21ed
15. Remove superflous box a4d9ca21de
16. Remove white background ccbfa14c76
17. katesalazar force-pushed on Nov 6, 2021
18. 
    katesalazar commented at 3:58 pm on November 6, 2021: contributor

    The commit message of rev 986e3a0 was wrong, fixed in ccbfa14 and force pushed, contents are the same.
19. 
    luke-jr commented at 10:02 pm on December 15, 2021: member

    The current PR looks nonsensical to me.
20. 
    kallewoof commented at 2:27 am on December 16, 2021: member

    At the very least squash into a single commit, I don’t see why this needs 6 separate ones.
21. 
    katesalazar commented at 8:23 am on December 16, 2021: contributor

    On Thu, Dec 16, 2021 at 3:27 AM kallewoof @.***> wrote:

    At the very least squash into a single commit, I don’t see why this needs 6 separate ones.

    Specifically wanted to defer squashing until concept feedback.

    — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bips/pull/1192#issuecomment-995381970, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4WZR6C3D5SGT5JRNGBTURFFABANCNFSM5EYX7WAA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

22. 
    katesalazar commented at 8:27 am on December 16, 2021: contributor

    On Wed, Dec 15, 2021 at 11:02 PM Luke Dashjr @.***> wrote:

    The current PR looks nonsensical to me.

    Do you mean the final rev figure, don’t you? Doesn’t it convey the same info of the initial figure?

    — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bips/pull/1192#issuecomment-995248554, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4WZIJRRVHPP5AVPLHADUREGBDANCNFSM5EYX7WAA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

23. vicariousdrama approved
24. luke-jr closed this on May 5, 2022

    ---

Contributors
katesalazar luke-jr kallewoof vicariousdrama

Labels
Proposed BIP modification