BIP 0174: Remove transparent background from figures #1193

pull katesalazar wants to merge 1 commits into bitcoin:master from katesalazar:202109261239 changing 2 files +4 −2
  1. katesalazar commented at 12:54 pm on September 26, 2021: contributor
    This is basically the same as #1184 and #1192. In 1192, node connections are visible, but with low contrast. In 1184 and in this case, arrows are barely visible at all.
  2. Remove transparent background from figures
    This increases contrast when reading on GitHub, if GitHub is switched
    to dark theme.
    9f87a75141
  3. katesalazar cross-referenced this on Sep 26, 2021 from issue BIP 0144: Remove transparent background from figure by katesalazar
  4. katesalazar cross-referenced this on Sep 26, 2021 from issue BIP 0156: Remove transparent background from figures. by katesalazar
  5. luke-jr added the label Proposed BIP modification on May 5, 2022
  6. luke-jr commented at 2:46 pm on May 5, 2022: member
    This is a bad idea IMO, but it’s @achow101 ’s call to make
  7. achow101 commented at 3:22 pm on May 5, 2022: member

    ACK 9f87a75141667fa5ed61023e4b07f572fa480b9c

    This is a bad idea IMO

    How so? With dark mode it’s difficult to see the arrows, so this change makes sense to me.

  8. luke-jr commented at 4:28 pm on May 5, 2022: member
    It just breaks dark mode for the image
  9. luke-jr merged this on May 5, 2022
  10. luke-jr closed this on May 5, 2022

  11. katesalazar commented at 8:25 pm on May 5, 2022: contributor
    Don’t worry, will iterate.
  12. katesalazar commented at 9:26 pm on May 13, 2022: contributor

    It just breaks dark mode for the image

    done in #1321

  13. Debrovozz commented at 5:19 am on May 16, 2022: none
  14. Debrovozz commented at 5:20 am on May 16, 2022: none
    О

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 01:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me