BIP 0144: Remove transparent background from figure #1194

pull katesalazar wants to merge 1 commits into bitcoin:master from katesalazar:202109261301 changing 1 files +0 −0
  1. katesalazar commented at 1:05 pm on September 26, 2021: contributor
    This is basically the same as #1184, #1192, and #1193. In 1192, node connections are visible, but with low contrast. In 1184 and in 1192 and in 1193 and in this case, there are figure elements, arrows or texts, barely visible at all, when GitHub is switched to dark theme.
  2. Remove transparent background from figure
    This increases contrast when reading on GitHub, if GitHub is switched
    to dark theme.
    02d1137e3e
  3. vicariousdrama approved
  4. luke-jr commented at 3:33 pm on May 5, 2022: member
    Dislike, up to @CodeShark @sipa
  5. luke-jr added the label Proposed BIP modification on May 5, 2022
  6. murchandamus assigned sipa on Apr 26, 2024
  7. jonatack commented at 9:31 pm on May 1, 2024: contributor
    Tested ACK 02d1137e3e2ffca24a1bfde21b5c0c70a4b507ce with GitHub dark mode, with and without the Dark Reader extension. The only visible difference with this patch is that the witnesstx illustration has a white background instead of a checkered white-and-grey one, and a green instead of brick-colored border. I find it easier to read.
  8. katesalazar commented at 10:25 pm on May 3, 2024: contributor

    It’s possible the only change here is just a removal of alpha from the PNG figure, but I can no longer tell.

    I should have written a more thorough commit message.

    On Wed, May 1, 2024 at 9:32 PM Jon Atack @.***> wrote:

    @.**** commented on this pull request.

    Tested ACK with GitHub dark mode, with and without the Dark Reader extension. nly difference is with this patch the witnesstx illustration has a white background instead of a checkered white-and-grey one, and a green instead of brick-colored border.

    — Reply to this email directly, view it on GitHub https://github.com/bitcoin/bips/pull/1194#pullrequestreview-2034493738, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4W4J2KBR526VOKGMUQLZAFNNDAVCNFSM5EYYY6N2U5DIOJSWCZC7NNSXTPCQOVWGYUTFOF2WK43UKJSXM2LFO45TEMBTGQ2DSMZXGM4A . You are receiving this because you authored the thread.Message ID: @.***>

  9. katesalazar commented at 11:16 pm on May 3, 2024: contributor

    Maybe we/you can alternatively perform a safe run of:

    0#!/bin/sh
    1
    2convert witnesstx.png -background white -alpha remove - | \
    3        sponge witnesstx.png
    

    In my host that yields a fig with MD5 6b15a18d5a1455f3e11663c3d65d86d2.

    The common base MD5 is f01ef36345d9073d8cba8501df9c5593.

    The figure I proposed in 2021 yields b99bc145dda861daef9a49bafe690f31.

  10. katesalazar commented at 11:22 pm on May 3, 2024: contributor
    Date makes the contents change.
  11. katesalazar marked this as a draft on May 3, 2024
  12. katesalazar commented at 11:25 pm on May 3, 2024: contributor
    Authors trust is required here, it can’t be me.
  13. katesalazar closed this on May 3, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 01:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me