BIP 0156: Remove transparent background from figures. #1195

1. 
   katesalazar commented at 1:16 pm on September 26, 2021: contributor

   This is similar to #1184, #1192, #1193, and #1194.
2. Remove transparent background from figures

   This increases contrast when reading on GitHub, if GitHub is switched
   to dark theme.

   0493ccbaa8
3. vicariousdrama approved
4. 
   luke-jr commented at 3:32 pm on May 5, 2022: member

   Dislike, but up to @gfanti @mablem8 @amiller @sbaks0820 @shaileshhbv
5. luke-jr added the label Proposed BIP modification on May 5, 2022
6. 
   murchandamus commented at 7:54 pm on April 26, 2024: contributor

   ACK 0493ccbaa85ea4543c3ea52aada122340bda837d, appears to resolve an accessibility issue for users of darkmode. It seems to me that the content is not changed, but I would prefer to get consent from at least one of the authors.
7. 
   jonatack commented at 11:08 pm on May 1, 2024: contributor

   Tested ACK 0493ccbaa85ea4543c3ea52aada122340bda837d it’s easier to read in various light/dark mode configurations
8. 
   katesalazar commented at 10:38 pm on May 3, 2024: contributor

   @mablem8 @amiller @gfanti
9. 
   katesalazar commented at 11:32 pm on May 3, 2024: contributor

   It can’t be me.
10. katesalazar closed this on May 3, 2024

    ---

11. 
    gfanti commented at 2:07 am on May 4, 2024: contributor

    Sorry for the delay, the change seems fine to me.
12. 
    murchandamus commented at 2:50 pm on May 6, 2024: contributor

    @katesalazar: It’s not clear to me why you closed the PR. Replacing the transparent background with a white background, which seems in line with black text, seems like a good change, and one of the original authors endorsed it now. Do you want to proceed instead of closing?
13. 
    katesalazar commented at 7:02 pm on May 6, 2024: contributor

    Hah, hey and sorry for the mess.

    I would prefer if someone else grabs it.

    You can do the figure edit in many ways, for example: #1194 (comment)

    On Mon, May 6, 2024 at 2:50 PM murchandamus @.***> wrote:

    @katesalazar https://github.com/katesalazar: It’s not clear to me why you closed the PR. Replacing the transparent background with a white background, which seems in line with black text, seems like a good change, and one of the original authors endorsed it now. Do you want to proceed instead of closing?

    — Reply to this email directly, view it on GitHub https://github.com/bitcoin/bips/pull/1195#issuecomment-2096219484, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4W6BSRIC7HIUZHE56HTZA6KDDAVCNFSM5EYZDYT2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBZGYZDCOJUHA2A . You are receiving this because you were mentioned.Message ID: @.***>

Contributors
katesalazar vicariousdrama luke-jr murchandamus jonatack gfanti

Labels
Proposed BIP modification