Minor Updates to BIP-119 #1215

pull JeremyRubin wants to merge 5 commits into bitcoin:master from JeremyRubin:ctv-updates changing 1 files +142 −43

JeremyRubin commented at 7:49 PM on October 15, 2021: contributor
This PR contains some minor updates to BIP-119 that clarify
1. Deployment params
2. CTV v.s. Anyprevout
3. Synergies with other softforks
4. The choice of SHA-256 v.s. RIPEMD
5. The choice of Untagged hash vs tagged
[BIP-119] Clarify Draft Deployment Params 8364e25ebc
[BIP-119] Better Explain AnyPrevout v.s. CTV 27466fa815
[BIP-119] Describe Synergies with future soft fork proposals afc605f8e2
[BIP-119] Explain Hash Function Choices b305d56352
JeremyRubin commented at 7:50 PM on October 15, 2021: contributor

cc @ajtowns

in bip-0119.mediawiki:226 in b305d56352 outdated

 224 | +NEVER_ACTIVE/NO_TIMEOUT, but this is subject to change while the BIP is a draft.
 225 |  
 226 | -For the avoidance of unclarity, the parameters are:
 227 | +For the avoidance of unclarity, the parameters to be determined are:
 228 |  
 229 | +     // Deployment of CTV (BIP 119)

kallewoof commented at 3:16 AM on October 16, 2021:

Indentation is off

in bip-0119.mediawiki:642 in b305d56352 outdated

 637 |  Older wallet software will be able to accept spends from OP_CHECKTEMPLATEVERIFY outputs, but will
 638 |  require an upgrade in order to treat PayToBareDefaultCheckTemplateVerifyHash chains with a confirmed ancestor as
 639 |  being "trusted" (i.e., eligible for spending before the transaction is confirmed).
 640 |  
 641 | +
 642 | +

kallewoof commented at 3:20 AM on October 16, 2021:

Don't think you need 3 newlines here.

JeremyRubin commented at 4:01 PM on October 16, 2021:

fixed these both in a followup commit rather than fixup as i noticed some other extra/missing whitespace.

kallewoof commented at 3:20 AM on October 16, 2021: member

Some nits. Feel free to ignore.
[BIP-119] Whitspace Consistency 6058f2f669
Chacaras74 commented at 3:22 PM on October 27, 2021: none

misery uniform fall chuckle sense rather tissue goat pepper fee plunge skull
Chacaras74 commented at 3:25 PM on October 27, 2021: none

gh pr checkout 1215
luke-jr merged this on Nov 4, 2021
luke-jr closed this on Nov 4, 2021

Contributors

JeremyRubin

kallewoof

Chacaras74