PSBT_OUT_TAP_LEAF_SCRIPT seemed to appear in output key sections by copy-paste from input section. First, it shares the same byte no as PSBT_OUT_TAP_TREE, second its description talks about "witness"
BIP-174: Removing PSBT_OUT_TAP_LEAF_SCRIPT #1241
pull dr-orlovsky wants to merge 2 commits into bitcoin:master from dr-orlovsky:patch-11 changing 1 files +0 −22-
dr-orlovsky commented at 5:43 PM on November 23, 2021: contributor
-
457e3545ba
BIP-174: Removing PSBT_OUT_TAP_LEAF_SCRIPT
`PSBT_OUT_TAP_LEAF_SCRIPT` seemed to appear in output key sections by copy-paste from input section. First, it shares the same byte no as `PSBT_OUT_TAP_TREE`, second its description talks about "witness"
-
achow101 commented at 5:46 PM on November 23, 2021: member
ACK 457e3545ba0954031865a820a2e3bbabbee984d9
-
achow101 commented at 8:58 PM on December 9, 2021: member
While we're making fixups like this, can you also remove
PSBT_GLOBAL_SIGHASH_SINGLE_INPUT? That's not part of BIP 370 anymore, and so shouldn't be listed in 174. -
kallewoof commented at 11:37 PM on December 9, 2021: member
Didn't realize this was RFM. Will wait for requested change.
-
BIP-174: Remove PSBT_GLOBAL_SIGHASH_SINGLE_INPUT d16522949d
-
dr-orlovsky commented at 11:55 AM on January 6, 2022: contributor
@achow101 sorry for taking that so long. Removed according to your suggestion
-
achow101 commented at 6:17 PM on January 6, 2022: member
ACK d16522949dbba2f3dc475f79f574814a4b3627f4
- kallewoof merged this on Jan 7, 2022
- kallewoof closed this on Jan 7, 2022
Contributors