[BIP-0119] Include test vectors for CTV in BIP's subdirectory #1260

pull JeremyRubin wants to merge 1 commits into bitcoin:master from JeremyRubin:ctv-test-vectors changing 4 files +2494 −0

JeremyRubin commented at 7:08 PM on December 25, 2021: contributor

This PR adds test vector files for those wishing to check CTV behavior matches Bitcoin Core / the BIP.
[BIP-0119] Include test vectors for CTV in BIP's subdirectory ae747e2b90
JeremyRubin commented at 7:09 PM on December 25, 2021: contributor

cc @glozow these match the test vectors currently in the BIP; you can cross reference those in review.

in bip-0119.mediawiki:255 in ae747e2b90

 250 | @@ -251,6 +251,9 @@ standardized later as policy changes.
 251 |  A reference implementation and tests are available here:
 252 |  https://github.com/JeremyRubin/bitcoin/tree/checktemplateverify.
 253 |  
 254 | +Test vectors are available in [/bip-0119/vectors the bip-0119/vectors
 255 | +directory] for checking compatibility with the refrence implementation and BIP.

glozow commented at 5:41 PM on January 3, 2022:

directory] for checking compatibility with the reference implementation and BIP.

glozow commented at 5:48 PM on January 3, 2022: member

utACK ae747e2b909ab5dd32632ed3a8b09839193d53e3 - I haven't verified that all the tests match the spec or how well it covers all permutations of scripts, but thanks for adding test vectors. Assuming the coverage is good, to a maintainer of a client that isn't Bitcoin Core, I imagine this would be much more helpful than trying to match the reference implementation.
luke-jr merged this on Jan 15, 2022
luke-jr closed this on Jan 15, 2022

Contributors

JeremyRubin

glozow