[BIP-174] Clarify that partial_sig should be a valid. #1270

pull JeremyRubin wants to merge 1 commits into bitcoin:master from JeremyRubin:patch-2 changing 1 files +1 −1
  1. JeremyRubin commented at 11:26 pm on January 8, 2022: contributor

    In discussing https://github.com/rust-bitcoin/rust-bitcoin/pull/669?notification_referrer_id=NT_kwDOAA2G-7EyNDgwMTU5NzIxOjg4NjUyMw#event-5861680619 it’s clear that the PSBT spec is ambiguous with respect to what values should be parseable for PSBTs, this patch clears up the ambiguity.


    Personally, I feel that the better path is to allow NULLDUMMY here, as there could be some situations whereby satisfaction is NP-hard without some indicator of use a signature or not:

    e.g., a contrived example (not saying you should do this) is

    0<0> toaltstack
    1<pk0> Checksig OP_IF FROMALTSTACK <V0> OP_ADD TOALTSTACK OP_ENDIF
    2<pk1> Checksig OP_IF FROMALTSTACK <V1> OP_ADD TOALTSTACK OP_ENDIF
    3...
    4<pkN> Checksig OP_IF FROMALTSTACK <VN> OP_ADD OP_ENDIF
    5<T> OP_EQUAL
    

    where to satisfy requires solving a subset-sum, so just collecting all valid signatures does not allow a polynomial time finalizer to solve by inference in many cases even if all signers add their signature.

    Of course, this isn’t the best example, but it is an example nonetheless.

  2. [BIP-174] Clarify that partial_sig should be a valid. 469d62ce2b
  3. apoelstra commented at 2:26 pm on January 10, 2022: contributor
    An alternate strategy would be to add an extra boolean “will not sign” field for this purpose. I agree that ought to be possible to signal this (even though such a signal would be non-binding of course, and even forgeable). But I don’t think that the partial signature field is the right tool for this job.
  4. luke-jr added the label Proposed BIP modification on Jan 15, 2022
  5. luke-jr commented at 11:15 pm on January 15, 2022: member
  6. achow101 commented at 0:43 am on January 16, 2022: member
    ACK 469d62ce2b42b42e30e7e348e5c7666ed8f938de
  7. luke-jr merged this on Jan 16, 2022
  8. luke-jr closed this on Jan 16, 2022

  9. bitcoin deleted a comment on Feb 18, 2022
  10. bitcoin locked this on Feb 18, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 01:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me