BIP 372: Pay-to-contract tweak fields for PSBT #1293

pull dr-orlovsky wants to merge 8 commits into bitcoin:master from BP-WG:bip/p2c changing 3 files +199 −1
  1. dr-orlovsky commented at 9:33 am on March 29, 2022: contributor
    A proposal was originally discussed in #1239 and than on a mailing list https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2022-January/019761.html
  2. dr-orlovsky cross-referenced this on Mar 29, 2022 from issue PSBT: Add pay-to-contract tweaks to tx inputs by dr-orlovsky
  3. dr-orlovsky commented at 6:22 am on April 1, 2022: contributor
    Asking @achow101 to review
  4. dr-orlovsky commented at 2:51 pm on April 20, 2022: contributor
    Kindly pining @achow101 to review. This is a stuff we briefly discussed with @apoelstra, basing also on his ideas, so his review is also highly appreciated.
  5. bitcoin deleted a comment on Apr 21, 2022
  6. apoelstra commented at 1:51 pm on April 25, 2022: contributor

    concept ACK. I like this approach, it’s narrow but general and clean. It could be used for hypothetical broken P2C schemes but I’m not too worried about that.

    Thank you for the authorship but AFAIR this approach is not mine.

  7. luke-jr added the label New BIP on May 5, 2022
  8. luke-jr commented at 11:18 pm on May 5, 2022: member
    Assigned BIP number 372
  9. luke-jr renamed this:
    BIP P2C proposal
    BIP 372: Pay-to-contract tweak fields for PSBT
    on May 5, 2022
  10. achow101 commented at 9:48 pm on July 25, 2022: member
    Seems fine to me. I’m not particularly familiar with p2c constructions, so can’t really pass further judgement on this topic.
  11. dr-orlovsky commented at 11:26 am on July 30, 2022: contributor
    @luke-jr whom do you think we need to review this PR before getting it merged?
  12. kallewoof commented at 3:43 am on August 2, 2022: member

    @luke-jr whom do you think we need to review this PR before getting it merged?

    The BIP was assigned number 372, so for starters edit the BIP to replace the “?” placeholders as appropriate. Also make sure to address the travis issues, if any.

  13. dr-orlovsky force-pushed on Aug 21, 2022
  14. BIP P2C proposal initial version 
    Signed-off-by: Dr. Maxim Orlovsky <orlovsky@pandoraprime.ch>
    5716f2878f
  15. Assign BIP-372 number to P2C BIP as per @kallewoof decision 
    Signed-off-by: Dr. Maxim Orlovsky <orlovsky@pandoraprime.ch>
    0337a6c64d
  16. Syntaxic proofs for BIP-372 
    Signed-off-by: Dr. Maxim Orlovsky <orlovsky@pandoraprime.ch>
    ad46e586d1
  17. Fix CI failure in BIP-372 
    Signed-off-by: Dr. Maxim Orlovsky <orlovsky@pandoraprime.ch>
    cdaccbedb5
  18. CI: Allow dashes in author e-mail domain names 
    Signed-off-by: Dr. Maxim Orlovsky <orlovsky@pandoraprime.ch>
    2f57890cbe
  19. dr-orlovsky force-pushed on Aug 21, 2022
  20. Assign Comments-URI for BIP-372 697de96475
  21. BIP-372: add entry to the README d2b4d5d099
  22. dr-orlovsky force-pushed on Aug 21, 2022
  23. dr-orlovsky commented at 7:57 pm on August 21, 2022: contributor

    @kallewoof did as you asked for.

    First, I have re-based on the current master since the master I was based before contained a CI failure, which was fixed in 66aed730432eedc1dadc5436d0e4dd7a6d3b5216

    I also had to fix the CI script in https://github.com/bitcoin/bips/pull/1293/commits/2f57890cbe439839f7a53f69232d1433fd727db0 since my e-mail contains dashes, which were not allowed by CI before.

    Finally I also created an entry in the README since it was required by the CI.

  24. kallewoof commented at 1:10 am on August 22, 2022: member
    Please don’t use @{username} in commit descriptions. It results in a lot of spammy notifications sent to that user. (Github should really do something about that.)
  25. dr-orlovsky commented at 8:22 am on August 22, 2022: contributor
    @kallewoof ok, sorry, I didn’t know
  26. kallewoof commented at 9:36 am on August 22, 2022: member
    No biggie. Github’s at fault here. But yeah, do avoid in the future :)
  27. dr-orlovsky commented at 3:29 pm on September 9, 2022: contributor
    @kallewoof any requirements what to do next with this PR in order to get the new BIP merged into the master?
  28. michaelfolkson commented at 3:49 pm on September 9, 2022: contributor

    Thank you for the authorship but AFAIR this approach is not mine.

    Apologies if I’m misunderstanding the context here but would you prefer to be listed in the acknowledgements rather than as a BIP co-author @apoelstra? Being listed as a co-author does seem to confer more perceived responsibility over the BIP than just being listed in the acknowledgements.

  29. apoelstra commented at 8:37 pm on September 9, 2022: contributor
    @michaelfolkson yes, I would prefer to be listed in the acknowledgements rather than as a co-author. This is not my BIP to maintain :)
  30. dr-orlovsky referenced this in commit b3dfb4bf2d on Sep 11, 2022
  31. dr-orlovsky commented at 9:01 am on September 11, 2022: contributor
    @michaelfolkson @apoelstra fixed
  32. BIP-372: Moving Andrew Poelstra from author to ACK section 
    Basing on https://github.com/bitcoin/bips/pull/1293#issuecomment-1242438684
    d7888e53aa
  33. dr-orlovsky force-pushed on Sep 11, 2022
  34. luke-jr merged this on Sep 29, 2022
  35. luke-jr closed this on Sep 29, 2022
  36. cryptoquick cross-referenced this on Oct 5, 2022 from issue October topics by justinmoon


dr-orlovsky apoelstra luke-jr achow101 kallewoof michaelfolkson

Labels
New BIP

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-23 09:10 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me