bip-326: avoid errors from scripts/buildtable.pl #1299

pull ajtowns wants to merge 1 commits into bitcoin:master from ajtowns:202204-longtitle changing 2 files +8 −3
  1. ajtowns commented at 0:46 am on April 7, 2022: contributor

    Merge of #1269 triggered CI errors due to script/buildtable.pl, in particular:

    • the Author: field is not a valid email address (" at " and " dot " rather than “@” and “.”)
    • missing Comments-URI
    • License code is wrong (should be “CC0-1.0” rather than “CC-0”)
    • the Title field is longer than the 44 char maximum (could perhaps be “Anti-fee-sniping in taproot transactions”, dropping the how and why)

    This makes the trivial changes to the BIP to add the Comments field and fix the License code, and updates buildtable.pl to avoid complaining about the email address and title.

  2. bip-326: avoid errors from scripts/buildtable.pl 234bb915f4
  3. ajtowns commented at 0:47 am on April 7, 2022: contributor
  4. kallewoof commented at 11:13 pm on April 14, 2022: member

    the Title field is longer than the 44 char minimum (could perhaps be “Anti-fee-sniping in taproot transactions”, dropping the how and why)

    I think you meant ‘maximum’ not ‘minimum’.

  5. MarcoFalke cross-referenced this on Apr 28, 2022 from issue [BIP-326]: Leave motivation out of title; fix travis by JeremyRubin
  6. JeremyRubin commented at 8:43 pm on April 28, 2022: contributor
    ACK please merge
  7. ajtowns commented at 3:36 am on April 29, 2022: contributor
    I think this is waiting on an ACK from @chris-belcher as the champion of a BIP this PR touches.
  8. chris-belcher commented at 9:09 am on April 29, 2022: contributor
    ACK
  9. fanquake referenced this in commit 34d211aa93 on May 4, 2022
  10. katesalazar commented at 12:14 pm on May 4, 2022: contributor
    ACK 234bb915f41f85eb8e9845bab5349fb2eec83246
  11. luke-jr merged this on May 5, 2022
  12. luke-jr closed this on May 5, 2022

  13. luke-jr commented at 3:05 pm on May 5, 2022: member
    Actually, why is this breaking scripts/buildtable.pl rather than fixing BIP 326???
  14. luke-jr cross-referenced this on May 5, 2022 from issue Bugfix: BIP 326: Correct Author/Title headings by luke-jr

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-22 04:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me