BIP 0174: bring back transparent background to figures #1321

pull katesalazar wants to merge 1 commits into bitcoin:master from katesalazar:202205132020 changing 6 files +3612 −851
  1. katesalazar commented at 8:32 pm on May 13, 2022: contributor
    tweaking tkiz arrows for luke-jr with <3
  2. katesalazar force-pushed on May 13, 2022
  3. katesalazar force-pushed on May 13, 2022
  4. katesalazar marked this as ready for review on May 13, 2022
  5. katesalazar force-pushed on May 13, 2022
  6. katesalazar commented at 5:26 am on May 14, 2022: contributor
    using white arrows with black borders should work sweetly in dark themes and in white themes
  7. katesalazar renamed this:
    BIP 0174: bring back transparent backgrounds to figures
    BIP 0174: bring back transparent background to figures
    on May 14, 2022
  8. katesalazar commented at 6:21 pm on May 14, 2022: contributor

    this shit is not very straightforward… I wonder how exactly did achow101 generate the svg pics.

    If I knew that, it’s possible I could rerun this in some way the svg text diff volume is less shitty than in 3248581928b5299525b32979c8a

    but I think the SVG visual diff is very mostly OK tho

  9. Bring back transparent background to figures
    Black arrows are visible only in light theme (unless white background
    for dark theme). Two-color arrows are visible in light theme and in
    dark theme.
    3248581928
  10. katesalazar force-pushed on May 22, 2022
  11. murchandamus commented at 8:16 pm on April 26, 2024: contributor
    @achow101: This appears to modify your BIP, any chance you could review?
  12. katesalazar commented at 8:44 pm on April 26, 2024: contributor

    this was sooo cool to investigate

    On Fri, Apr 26, 2024 at 8:17 PM murchandamus @.***> wrote:

    @achow101 https://github.com/achow101: This appears to modify your BIP, any chance you could review?

    — Reply to this email directly, view it on GitHub https://github.com/bitcoin/bips/pull/1321#issuecomment-2080061519, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4W7BS3T77FOO5ZWSU3TY7KY33AVCNFSM5V4NLEBKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBYGAYDMMJVGE4Q . You are receiving this because you authored the thread.Message ID: @.***>

  13. achow101 commented at 8:50 pm on April 26, 2024: member

    ACK 3248581928b5299525b32979c8a569ce9107fdfc

    The new images look good in both light and dark mode.

    I wonder how exactly did achow101 generate the svg pics.

    I don’t remember either. But the build script in here produces valid svgs, so I guess it’s fine.

  14. murchandamus merged this on Apr 26, 2024
  15. murchandamus closed this on Apr 26, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 03:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me