[BIP322] Change private key format from wif to hex #1332

pull azuchi wants to merge 1 commits into bitcoin:master from azuchi:fix_bip322_private_key_format changing 1 files +1 −1
  1. azuchi commented at 2:41 am on June 12, 2022: contributor

    The specification for deriving a bech32 address from a wif format private key does not appear to be standardized.

    Some wallets, such as Electrum, set a marker in the first byte, and BIP-0178 propose an extended WIF format.

    The WIF data currently described is ambiguous as to which address is should be derived, so it would be better to describe it as a hex value.

  2. [BIP322] Change private key format from wif to hex 51df3f3849
  3. bitcoin deleted a comment on Jul 12, 2022
  4. kallewoof commented at 3:49 am on July 12, 2022: member
    The WIF (Wallet Import Format) is a standard for representing private keys. Whatever address type you derive from them is literally up to you. Attaching an address hint to the private key serialization is precisely what the two instances you pointed to are doing, but they’re still WIF. Switching to hex seems like a downgrade, as it unnecessarily removes the checksum built into WIF, and such, for no particular reason.
  5. luke-jr commented at 9:21 pm on July 25, 2022: member
    @kallewoof Close this?
  6. luke-jr added the label Proposed BIP modification on Jul 25, 2022
  7. murchandamus commented at 8:29 pm on April 26, 2024: contributor
    It seems to me that the BIP author is in disagreement with this change suggestion. I recommend that this PR be closed after 2024-05-10 unless there is further activity here that indicates otherwise.
  8. murchandamus added the label Pending acceptance on May 8, 2024
  9. murchandamus commented at 3:38 pm on May 31, 2024: contributor
    As discussed prior, I’m closing this given no additional input
  10. murchandamus closed this on May 31, 2024

  11. murchandamus removed the label Pending acceptance on May 31, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 01:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me