Update bip-0300.mediawiki with consistent use of “ACK-counter” term #1333

pull 54627384 wants to merge 1 commits into bitcoin:master from 54627384:patch-1 changing 1 files +4 −4
  1. 54627384 commented at 0:26 am on June 19, 2022: contributor

    I have updated all instances of “ACK Value” and “ACK Counter Value” within the BIP to be “ACK-counter”.

    Updates made to align with term used through out the BIP: Line 213 - adding explicit mention of “ACK-counter” Line 229 - adding explicit mention of “ACK-counter” Line 257 - replaced “ACK-value” with “ACK-counter” Line 288 - replaced “ACK value” with “ACK-counter”

  2. Update bip-0300.mediawiki
    I've assumed that all mentions of ACK value and ACK counter are synonymous and therefore have updated all instances of this within the BIP to be "ACK-counter". I've noticed that M4 shows the different terms on two different lines (Line 256 and Line 257), which has made me think that potentially these terms aren't synonymous. 
    
    Updates made to align with term used through out the BIP:
    Line 213 - adding explicit mention of "ACK-counter"
    Line 229 - adding explicit mention of "ACK-counter"
    Line 257 - replaced "ACK-value" with "ACK-counter"
    Line 288 - replaced "ACK value" with "ACK-counter"
    858b6beb79
  3. luke-jr added the label Proposed BIP modification on Jul 25, 2022
  4. luke-jr commented at 9:27 pm on July 25, 2022: member
  5. psztorc commented at 9:27 am on July 28, 2022: contributor

    I don’t have a problem with it.

    It seems like a very small change to me. But the author of the pull request insists that it would have been easier for him to understand, had it been worded like this. So it is fine by me.

  6. luke-jr merged this on Jul 28, 2022
  7. luke-jr closed this on Jul 28, 2022

  8. 54627384 deleted the branch on Jul 28, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 01:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me