Revert "Fix incorrect signature test vectors in BIP322" #1336

pull Mertz22 wants to merge 1 commits into bitcoin:master from Mertz22:revert-1323-master changing 1 files +2 −14

Mertz22 commented at 2:54 AM on June 30, 2022: none

Reverts bitcoin/bips#1323
Revert "Fix incorrect signature test vectors in BIP322" cfba249abc
kallewoof commented at 6:11 AM on June 30, 2022: member

I am pretty sure I confirmed #1323 before it was merged. Why revert?
MarcoFalke commented at 6:52 AM on June 30, 2022: member

Pretty sure it's spam
kallewoof commented at 9:19 AM on June 30, 2022: member

All right, closing. Will reopen if given a reason.
kallewoof closed this on Jun 30, 2022
kyranjamie commented at 9:25 AM on March 25, 2023: none
Afaict the BIP continues to have incorrect test vectors.

Per the tests in the Bitcoin Core, the base64 signature of "Hello World", with key from bip, should be:
```
AkgwRQIhAOzyynlqt93lOKJr+wmmxIens//zPzl9tqIOua93wO6MAiBi5n5EyAcPScOjf1lAqIUIQtr3zKNeavYabHyR8eGhowEhAsfxIAMZZEKUPYWI4BruhAQjzFT8FSFSajuFwrDL1Yhy
```
I get this result in my JS implementation.

In the bip0322-signatures repo (bottom of notebook), @wip-abramson says they'll make a PR to update this. But, it looks like it wa updated with yet another result. @kallewoof @MarcoFalke @wip-abramson

Contributors