psbt: Unify formatting of key-value data to specify data type and name #1345

pull achow101 wants to merge 1 commits into bitcoin:master from achow101:psbt-clarify-serialization-data changing 3 files +80 −80

achow101 commented at 7:10 PM on July 13, 2022: member

No description provided.

in bip-0174.mediawiki:282 in dbfb28cfa9 outdated

 275 | @@ -276,9 +276,9 @@ The currently defined per-input types are defined as follows:
 276 |  |-
 277 |  | BIP 32 Derivation Path
 278 |  | <tt>PSBT_IN_BIP32_DERIVATION = 0x06</tt>
 279 | -| <tt><pubkey></tt>
 280 | +| <tt><bytes pubkey></tt>
 281 |  | The public key
 282 | -| <tt><32-bit uint> <32-bit uint>*</tt>
 283 | +| <tt><4 byte fingerprint> <32-bit uint path element>*</tt>
 284 |  | The master key fingerprint as defined by BIP 32 concatenated with the derivation path of the public key. The derivation path is represented as 32 bit unsigned integer indexes concatenated with each other. Public keys are those that will be needed to sign this input.

jgriffiths commented at 11:58 PM on July 13, 2022:

32 bit little endian unsigned integer, also elsewhere I think

achow101 commented at 12:20 AM on July 14, 2022:

Done

in bip-0371.mediawiki:70 in dbfb28cfa9 outdated

  67 |  | 0, 2
  68 |  |-
  69 |  | Taproot Leaf Script
  70 |  | <tt>PSBT_IN_TAP_LEAF_SCRIPT = 0x15</tt>
  71 | -| <tt><control block></tt>
  72 | +| <tt><bytes jcontrol block></tt>

jgriffiths commented at 12:01 AM on July 14, 2022:

typo? jcontrol

achow101 commented at 12:21 AM on July 14, 2022:

Fixed.

jgriffiths approved
jgriffiths commented at 12:02 AM on July 14, 2022: none

ack, with the above comments fixed
psbt: Unify formatting of key-value data to specify data type and name 7cd8ecd111
achow101 force-pushed on Jul 14, 2022
luke-jr merged this on Jul 25, 2022
luke-jr closed this on Jul 25, 2022

Contributors

achow101

jgriffiths