bip-141: improve witness field wording #1346

pull evanlinjin wants to merge 1 commits into bitcoin:master from evanlinjin:bip141-improve-wording changing 1 files +1 −1
  1. evanlinjin commented at 10:40 am on July 14, 2022: contributor

    When describing the witness field, reword “witness data” to “witness field” as “witness data” refers also to the marker and flag fields.

    The confusion

    https://github.com/bitcoin/bips/blob/master/bip-0141.mediawiki#transaction-size-calculations

    Base transaction size is the size of the transaction serialised with the witness data stripped.

    Here, “witness data” refers to having the marker, flag and witness fields stripped.

    https://github.com/bitcoin/bips/blob/master/bip-0141.mediawiki#transaction-id

    The witness is a serialization of all witness data of the transaction.

    However, here “witness data” refers to just the witness field.

  2. bip-141: `witness` field wording improvement
    When describing the `witness` field, reword "witness data" to "witness
    field" as "witness data" refers also to the `marker` and `flag` fields.
    ac80e11298
  3. evanlinjin force-pushed on Jul 14, 2022
  4. evanlinjin renamed this:
    bip-141: `witness` field wording improvement
    bip-141: improve `witness` field wording
    on Jul 14, 2022
  5. luke-jr added the label Proposed BIP modification on Jul 25, 2022
  6. luke-jr commented at 9:22 pm on July 25, 2022: member
  7. sipa commented at 9:24 pm on July 25, 2022: member
    ACK ac80e11298390f24dbf7160a48edec9142ac0085
  8. luke-jr merged this on Jul 25, 2022
  9. luke-jr closed this on Jul 25, 2022


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 01:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me