bip-0011/12 - fixed broken implementation url #1351

1. 
   russeree commented at 10:02 pm on August 12, 2022: contributor

   Replaced the current implementation URL which gives an error 404. The new link is to the equivalent branch since the original named branch has been removed.
2. russeree renamed this:
   bip-0012 - fixed broken implementation url
   bip-0011/12 - fixed broken implementation url
   on Aug 13, 2022
3. fixed bip-0011/12 broken url - implementation

   fixed bip-0012 broken url - implementation
   
   fixed bip-0011 broken url - implementation

   df9c3fa977
4. russeree force-pushed on Aug 13, 2022
5. in bip-0011.mediawiki:57 in df9c3fa977 outdated

   53@@ -54,7 +54,7 @@ A weaker argument is OP_CHECKMULTISIG should not be used because it pops one too
   54 
   55 OP_CHECKMULTISIG is already supported by old clients and miners as a non-standard transaction type.
   56 
   57-https://github.com/gavinandresen/bitcoin-git/tree/op_eval
   58+https://github.com/gavinandresen/bitcoin-git/tree/e679ec969c8b22c676ebb10bea1038f6c8f13b33
   

   ---

   ---

   

   luke-jr commented at 10:14 pm on September 29, 2022:

   This is an old commit. Why not the most recent 77f21f1583deb89bf3fffe80fe9b181fedb1dd60?

   Or perhaps link https://github.com/bitcoin/bitcoin/pull/669/files ?

   ---

   

   russeree commented at 11:55 pm on September 29, 2022:

   Updated Commit

   Ack’d to fixing with the more modern commit.

   The reason I chose the commit was it was referenced as the OP_EVAL implementation by Gavin Andresen in bip11/12 and would match the branch at the time the BIP was submitted. Though yours is newer and would represent the final state of the branch before the branch was removed.

   My method to determine the location of the deleted branch was to run git log --all --full-history -- "**op_eval*"

   The result provided this as well as your commit linked.

   

   In regards to the “Or perhaps”.

   I feel this would be the most appropriate solution for the brokens links as it was the entire merged implementation of the code changes, but isn’t Gavin Andresen original ‘implementation’.

   Advantages to this method

   • Actual implementation into BitcoinQt is clear.
   • Preserved as a part of the bitcoin/bitcoin repo.

   Disadvantages to this method

   • Doesn’t wholly represent the BIP authors implementation.

   Closing statement.

   I would like to implement it as a link to Gavins implementation as to preserve the original BIP as much as possible.

   If you would like to use the link to the OP_EVAL and merge into bitcoin/bitcoin I can do that as well. Please let me know which fix you would like and I will implement immediately.

   ---

   

   luke-jr commented at 0:22 am on September 30, 2022:

   I’m not sure there was a distinction between the “original” and the final version in this sense - BIPs typically get updated as the proposal changes.

   But ultimately, it’s a question of what @gavinandresen will ACK here.

6. luke-jr changes_requested
7. luke-jr added the label Proposed BIP modification on Sep 29, 2022
8. Update BIP 11/12 OP_EVAL implementation commit url 61d6631e5b
9. 
   gavinandresen commented at 7:12 pm on September 30, 2022: contributor

   ACK.

   (but I’m retired, so please stop mentioning me and just use common sense from now on)

10. luke-jr merged this on Sep 30, 2022
11. luke-jr closed this on Sep 30, 2022

    ---

Contributors
russeree luke-jr gavinandresen

Labels
Proposed BIP modification