The <valuedata> description field for PSBT_GLOBAL_TX_VERSION on these two BIPs list the type as a signed int, where the <valuedata> lists it as a uint.
BIP0174 and BIP0370 PSBT_GLOBAL_TX_VERSION <valuedata> type correction #1416
pull Shadouts wants to merge 1 commits into bitcoin:master from Shadouts:master changing 2 files +2 −2-
Shadouts commented at 11:20 PM on February 7, 2023: contributor
-
achow101 commented at 1:41 AM on February 8, 2023: member
It's supposed to be signed as the version in a transaction is also signed, the
<valuedata>is incorrect. -
Shadouts commented at 5:46 PM on February 8, 2023: contributor
Adjusted valuedata to
intto match description for signed int. - Shadouts renamed this:
BIP0174 and BIP0370 PSBT_GLOBAL_TX_VERSION <valuedata> description type correction
BIP0174 and BIP0370 PSBT_GLOBAL_TX_VERSION <valuedata> type correction
on Feb 8, 2023 -
achow101 commented at 5:49 PM on February 8, 2023: member
You can just drop the first commit and it's revert. They don't need to be in the commit history.
-
Fix valuedata type to match description. 1c5572b617
- Shadouts force-pushed on Feb 8, 2023
- kallewoof merged this on Feb 9, 2023
- kallewoof closed this on Feb 9, 2023
-
Ghost19804 commented at 6:07 AM on February 15, 2023: none
K
- bitcoin deleted a comment on Feb 17, 2023
- bitcoin deleted a comment on Feb 19, 2023
- bitcoin deleted a comment on Feb 20, 2023
- bitcoin locked this on Feb 20, 2023
Contributors