PSBTv0: Update Simple Signer Algorithm for SegWitv0 inputs #1430

pull bigspider wants to merge 1 commits into bitcoin:master from bigspider:psbtv0-fix-signing-algo changing 1 files +9 −9

bigspider commented at 11:33 AM on March 4, 2023: contributor
The Simple Signer Algorithm is not updated to the fact that SegWitv0 inputs are now typically expected to have both the non-witness-utxo and the witness-utxo field (instead of the ealier requirement of omitting the non-witness-utxo).

By reverting the order of the checks, it is at least semantically correct.

Possible TODOs for followups:
- Update for segwitv1 signing
- Recommend checking the non-witness-utxo for segwitv0 inputs.

Update Simple Signer Algorithm for SegWitv0 inputs

It is no longer expected that SegWitV0 inputs have no witness-utxo field.
Reverting the order of checks avoids this assumption (while still relying on the mandatory lack of witness-utxo for legacy inputs).

e538fa8562

bigspider renamed this:
~~Update Simple Signer Algorithm for SegWitv0 inputs~~
PSBTv0: Update Simple Signer Algorithm for SegWitv0 inputs
on Mar 4, 2023
achow101 commented at 6:42 PM on March 6, 2023: member

ACK e538fa8562fe26f814e544836991048383d225af
kallewoof merged this on Mar 8, 2023
kallewoof closed this on Mar 8, 2023

Contributors

bigspider

achow101