BIP-174: add SLIP-0019 fields #1434

pull louneskmt wants to merge 1 commits into bitcoin:master from louneskmt:bip174-slip19 changing 1 files +22 −0
  1. louneskmt commented at 7:19 pm on March 16, 2023: none
    The PSBT extension section of the SLIP-0019 has just been clarified and updated in https://github.com/satoshilabs/slips/commit/019bcd62178a086de36523689c2118819053158b.
  2. BIP-174: add SLIP-0019 fields b54a711221
  3. fiudzy approved
  4. fiudzy approved
  5. fiudzy approved
  6. murchandamus commented at 6:14 pm on May 1, 2024: contributor
    @achow101: could you review this when you have a chance?
  7. achow101 commented at 6:26 pm on May 1, 2024: member

    Tend to NACK. IMO every non-proprietary PSBT field should be defined in a BIP. If you don’t want to do that, use a proprietary field. I prefer to be very strict with that as otherwise we open up people to start defining their own fields and someone having to go and hunt down every unBIP’d usage of a field number, which is just an insane maintenance burden. We also want to avoid conflicting field numbers, so requiring everything to be a BIP will actually standardize what each field number means.

    Note that field number 0x19 collides with proposed field numbers in #1540

  8. jonatack commented at 6:36 pm on May 1, 2024: contributor
    Closing per BIP author feedback (thanks @achow101).
  9. jonatack closed this on May 1, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 17:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me