bip93: minor cleanups #1439

pull apoelstra wants to merge 4 commits into bitcoin:master from apoelstra:2023-03--bip93-cleanup changing 1 files +34 −31

apoelstra commented at 2:16 PM on March 29, 2023: contributor

This adds two new test vectors, but otherwise purely corrects grammar/syntax mistakes and makes no changes to the BIP content.

bip93: More invalid test vectors

These examples are valid BIP-173 and BIP-350 strings (but not valid BIP-93 strings).

838fd93219

bip93: make bech32 capitalization consistently lowercase eb62f6ea71
bip93: typo fixes, and fix URL format c3b330fdec
kallewoof commented at 12:54 AM on March 30, 2023: member

So, strictly speaking, a BIP change needs to be approved by an author, but seeing as you were the one who originally posted the BIP, this seems like a silly requirement to make here. It would be great if you added yourself to the authors list along with this change, so we don't have to try to find people who aren't even on github to approve of changes.
apoelstra commented at 1:49 AM on March 30, 2023: contributor

@kallewoof sure, I've added myself as an author.

I think this is probably fine since I did PR the original BIP text, but if you'd like I can get Pearlwort to send you (or somebody) an email.
apoelstra force-pushed on Mar 30, 2023
kallewoof commented at 2:11 AM on March 30, 2023: member

Malformed Author line in bip-0093.mediawiki at scripts/buildtable.pl line 130, <$F> line 5.

I think it doesn't like the and?
apoelstra force-pushed on Mar 30, 2023
add myself as a BIPs author c02efd1456
apoelstra force-pushed on Mar 30, 2023
apoelstra commented at 3:11 AM on March 30, 2023: contributor

I think it's about having multiple email addresses on one line. Fixed.
kallewoof merged this on Mar 30, 2023
kallewoof closed this on Mar 30, 2023
apoelstra deleted the branch on Mar 30, 2023

Contributors