Fixes the table entry for entropy := 512 in section PWD BASE85, that looks like a copy-paste error.
fix(bip85): rectify pwd_length in PWD BASE85 table #1469
pull theborakompanioni wants to merge 1 commits into bitcoin:master from theborakompanioni:patch-1 changing 1 files +1 −1-
theborakompanioni commented at 8:22 AM on June 30, 2023: contributor
-
fix(bip85): rectify pwd_length in PWD BASE85 table 265d64cae5
-
luke-jr commented at 10:38 PM on July 2, 2023: member
- luke-jr added the label Proposed BIP modification on Jul 2, 2023
- jonatack approved
-
jonatack commented at 4:16 PM on May 6, 2024: contributor
ACK 265d64cae5ae5a931d45dc9f923c562f33428e91. I agree that it looks like a copy-paste error or simple oversight.
-
jonatack commented at 4:17 PM on May 6, 2024: contributor
@ethankosakovsky mind having a quick look? This patch appears to be correct.
-
murchandamus commented at 5:07 PM on May 6, 2024: contributor
That was also the impression I had
-
jonatack commented at 4:48 PM on May 10, 2024: contributor
The last GitHub activity of the BIP author was 3 years ago in May 2021, so it may be impractical to gate this trivial fixup on their feedback. Happy to revert if anyone objects.
- jonatack merged this on May 10, 2024
- jonatack closed this on May 10, 2024
Contributors