The reject code 0x12 is used for Version duplicate, but also when an input is already spent (bad-txns-inputs-spent)
Reject code DUPLICATE also used for rejecting tx #148
pull NicolasDorier wants to merge 1 commits into bitcoin:master from NicolasDorier:patch-6 changing 1 files +2 −0-
NicolasDorier commented at 4:56 PM on March 26, 2015: contributor
-
cb6f731f62
Reject code DUPLICATE also used for rejecting tx
The reject code 0x12 is used for Version duplicate, but also when an input is already spent (bad-txns-inputs-spent)
-
laanwj commented at 8:14 AM on May 26, 2015: member
Ping author @gavinandresen
-
schildbach commented at 8:35 AM on May 26, 2015: contributor
I suggested this to Gavin when BIP61 was presented, but he rejected.
-
NicolasDorier commented at 12:03 PM on May 26, 2015: contributor
well, I can say this is as is implemented today. When a BIP and bitcoin core differ, I think we should change the BIP.
-
laanwj commented at 3:55 PM on May 26, 2015: member
That's a fact for consensus code. The code is leading there because it's too hard to change anything.
But I'm not sure in this case. If the overlap in numbers is not intentional, changing the code is also a possibility. But I'm also fine with documenting as-is.
-
gavinandresen commented at 5:59 PM on May 26, 2015: contributor
ACK on this change.
RE: BIP versus reference implementation code: I agree with @laanwj -- the reference implementation defines consensus, but for non-consensus things like this either the BIP or the implementation can be changed.
- laanwj referenced this in commit 5773aa4693 on Jun 22, 2015
- laanwj merged this on Jun 22, 2015
- laanwj closed this on Jun 22, 2015
- laanwj cross-referenced this on Feb 9, 2016 from issue Reject behavior does not coincide with BIP0061 by davecgh
- luke-jr referenced this in commit 9dc3c5bf4a on Jun 6, 2017
- ajtowns referenced this in commit 4b25ff7b92 on Dec 11, 2019
Contributors