Update bip45 based on comments by dskloet #149

maraoz commented at 6:08 PM on April 13, 2015: contributor

fix examples
fix address discovery section
fix purpose to 45
mention difference with bip-0044

maraoz referenced this in commit bd0da6f44a on Apr 20, 2015

in bip-0045.mediawiki:None in 686847a672 outdated

 172 | -# derive the external chain node of this account
 173 | -# scan addresses of the external chain; respect the gap limit described below
 174 | -# if no transactions are found on the external chain stop discovery
 175 | -# if there are some transactions, increase the account index and go to step 1
 176 | +# for each cosigner:
 177 | +# derive the cosigner's node (`m / purpose' / cosigner_index`)

dskloet commented at 8:43 PM on April 20, 2015:

Above you replaced $purpose with 45'. Do you want to do that here as well?

maraoz commented at 4:21 PM on April 27, 2015:

yeah, will fix

in bip-0045.mediawiki:None in 686847a672 outdated

 173 | -# scan addresses of the external chain; respect the gap limit described below
 174 | -# if no transactions are found on the external chain stop discovery
 175 | -# if there are some transactions, increase the account index and go to step 1
 176 | +# for each cosigner:
 177 | +# derive the cosigner's node (`m / purpose' / cosigner_index`)
 178 | +# for both the external and internal chains on this node (`m / purpose' / cosigner_index / 0` and `m / purpose' / cosigner_index / 1`)

dskloet commented at 8:44 PM on April 20, 2015:

end with a colon as on line 170:

in bip-0045.mediawiki:None in 686847a672 outdated

 183 | -"Account" above.
 184 |  
 185 | -Please note that the algorithm works with the transaction history, not account
 186 | -balances, so you can have account with total 0 coins and the algorithm will
 187 | -still continue with discovery.
 188 | +Please note that the algorithm uses the transaction history, not address

dskloet commented at 8:45 PM on April 20, 2015:

Did you mean to keep 2 blank lines above this one?

in bip-0045.mediawiki:None in 686847a672 outdated

 176 | +# for each cosigner:
 177 | +# derive the cosigner's node (`m / purpose' / cosigner_index`)
 178 | +# for both the external and internal chains on this node (`m / purpose' / cosigner_index / 0` and `m / purpose' / cosigner_index / 1`)
 179 | +# scan addresses of the chain; respect the gap limit described below
 180 |  
 181 | -This algorithm is correct, because software should disallow creation of new

dskloet commented at 8:46 PM on April 20, 2015:

If you want, you can put in a reminder that, opposite to BIP44, each cosigner branch needs to be checked, even if the earlier ones don't have transactions.

laanwj commented at 8:16 AM on May 26, 2015: member

Let me know when this is ready for merging

maraoz force-pushed on May 26, 2015

Update bip45 based on comments by dskloet

- fix examples
- fix address discovery section
- fix purpose to 45
- mention difference with bip-0044

dc0107f3c8

maraoz force-pushed on May 26, 2015

maraoz commented at 6:54 PM on May 26, 2015: contributor

Addressed all comments by @dskloet. When he ACKs, we can merge. Thanks @laanwj :+1:

dskloet commented at 7:31 PM on May 26, 2015: none

LGTM

laanwj referenced this in commit d457fa2f8e on Jun 22, 2015

laanwj merged this on Jun 22, 2015

laanwj closed this on Jun 22, 2015

maraoz deleted the branch on Jun 22, 2015