Remove duplicate word in bip-0085.mediawiki #1530

pull nau wants to merge 1 commits into bitcoin:master from nau:patch-1 changing 1 files +1 βˆ’1
  1. nau commented at 10:00 am on December 15, 2023: contributor
    Fix doublicated word
  2. Update bip-0085.mediawiki
    Fix doublicated word
    b434f1813c
  3. luke-jr commented at 7:15 pm on December 26, 2023: member
  4. luke-jr added the label Proposed BIP modification on Dec 26, 2023
  5. Skyeenicole approved
  6. illesdavid approved
  7. Skyeenicole approved
  8. Skyeenicole commented at 7:22 am on February 2, 2024: none
    How does withdrawal work?
  9. Skyeenicole approved
  10. Skyeenicole approved
  11. Skyeenicole commented at 9:14 pm on April 12, 2024: none
    πŸ˜΅β€πŸ’«
  12. jonatack renamed this:
    Update bip-0085.mediawiki
    Remove duplicate word in bip-0085.mediawiki
    on Apr 22, 2024
  13. jonatack approved
  14. jonatack commented at 5:21 pm on April 22, 2024: contributor

    ACK b434f1813ca2d4c270b51e53a4b7acd52f69bf60

    This is a trivial typo and the change does not alter the meaning of the sentence. In which case, I don’t think it is necessary for the original author to weigh in. It’s arguably a waste of their time to do so and best to clear this kind of PR off the table to focus review on more impactful ones.

  15. murchandamus approved
  16. murchandamus commented at 5:32 pm on April 22, 2024: contributor

    I agree with @jonatack’s assessment here. This PR only fixes a typo and the meaning of the document is not materially changed.

    0-GPG capable smart-cards SHOULD be be loaded as follows:
    1+GPG capable smart-cards SHOULD be loaded as follows:
    

    ACK b434f1813ca2d4c270b51e53a4b7acd52f69bf60

  17. Roasbeef merged this on Apr 23, 2024
  18. Roasbeef closed this on Apr 23, 2024

  19. in bip-0085.mediawiki:367 in b434f1813c
    363@@ -364,7 +364,7 @@ The resulting RSA key can be used to create a GPG key where the creation date MU
    364 
    365 Note on GPG key capabilities on smartcard/hardware devices:
    366 
    367-GPG capable smart-cards SHOULD be be loaded as follows: The encryption slot SHOULD be loaded with the ENCRYPTION capable key; the authentication slot SHOULD be loaded with the AUTHENTICATION capable key. The signature capable slot SHOULD be loaded with the SIGNATURE capable key.
    


    Skyeenicole commented at 1:22 am on April 24, 2024:
    ]()

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-01 00:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me