The first example (Native P2WPKH) signature in BIP 143 was missing a SIGHASH flag. The signature scheme requires a DER encoded signature with a one-byte SIGHASH/'hash type' flag appended. (Excepting schnorr signatures which can omit a flag to implicitly signal SIGHASH_DEFAULT)
This pull request corrects the example to include the 0x01 / SIGHASH_ALL flag.
The first example ('Native P2WPKH') signature in BIP 143 was missing
a SIGHASH flag. The signature scheme requires a DER encoded signature
with a one-byte SIGHASH/'hash type' flag appended. (Excepting schnorr
signatures which can omit a flag to implicitly signal SIGHASH_DEFAULT)
ACK, since all other examples have the sighash flag appended in the signature. Either this or include a new field "sighash flag" and exclude the sighash flag from all other signature examples
This addresses an error in the example provided for Native P2WPKH (Pay to Witness Public Key Hash) signatures in BIP 143. In Bitcoin transaction signatures, a SIGHASH flag indicates which parts of the transaction are covered by the signature. The correction ensures that the example includes the proper SIGHASH_ALL flag (0x01), which signifies that all inputs and outputs are covered by the signature.
This correction is crucial for clarity and correctness in implementing the BIP 143 standard, as the absence of the SIGHASH flag would lead to incorrect signature generation or verification.
Duplicate of #748