It seems GitHub has some problem interpreting quintuple single quotes on the blame and styles-enriched-raw renderings.
Edited using the browser, pending rebase and fixup.
BIP38, help GitHub intermediate syntax highlighter #1586
pull katesalazar wants to merge 2 commits into bitcoin:master from katesalazar:20240504 changing 1 files +4 −4-
katesalazar commented at 3:25 PM on May 4, 2024: contributor
-
katesalazar commented at 3:30 PM on May 4, 2024: contributor
I'd prefer reporting upstream before here, but IDK how.
-
murchandamus commented at 2:57 PM on May 6, 2024: contributor
I understand the first change where you add the missing double single quotes to close the italicized phrase, but it’s not clear to me what problem this generally solves, since the before and after render the same for me. Could you clarify your motivation for this PR?
-
katesalazar commented at 7:12 PM on May 6, 2024: contributor
Yeah, I actually thought about adding some screenshots. :sweat_smile:
First try to find something wrong here:
If you were able to find something wrong in the previous figure, then try to find a fix here:
-
murchandamus commented at 8:24 PM on May 6, 2024: contributor
I see. I didn’t notice that the Specification section was italicized before.
-
murchandamus commented at 1:38 PM on May 7, 2024: contributor
Okay, please feel free to ping me for review when this is ready to be merged.
-
4ddb0cc893
Update bip-0038.mediawiki
Add missing closing double single quote. The italicized paragraph gets cautiously closed.
-
c88a018409
Update bip-0038.mediawiki
Separating the bold and the italic markup helps inconsistent parsing (see screenshots in PR #1586).
- katesalazar force-pushed on May 7, 2024
- katesalazar marked this as ready for review on May 7, 2024
-
katesalazar commented at 3:58 PM on May 7, 2024: contributor
Waiting for further feedback, I see no urgency justifying pinging.
-
murchandamus commented at 12:49 PM on May 8, 2024: contributor
This fixes a minor formatting issue that appears in the GitHub online editor with quintuple quotes and closes an italicized phrase by adding the missing closing symbol.
- murchandamus merged this on May 8, 2024
- murchandamus closed this on May 8, 2024
Contributors