bip-0322: add another valid sig vector not to confuse #1598

pull ChrisCho-H wants to merge 1 commits into bitcoin:master from ChrisCho-H:master changing 1 files +2 −2

ChrisCho-H commented at 6:58 am on May 15, 2024: contributor

Following this discussion, add another valid sig vector not to confuse developer. It has been misleading some developers, as they think their implementation is wrong even if it’s right. This test vector is also included in ongoing implementation of BIP322(PR is closed but seems like still in development here)
bip-0322: add another valid sig vector not to confuse 2f311cc629
murchandamus commented at 3:03 pm on May 15, 2024: contributor

Pinging @kallewoof
murchandamus added the label Proposed BIP modification on May 15, 2024
murchandamus added the label Pending acceptance on May 15, 2024
bitcoin deleted a comment on May 15, 2024
bitcoin deleted a comment on May 15, 2024
kallewoof commented at 0:37 am on May 16, 2024: member

LGTM, atlhough it might be good if @luke-jr OK’d as well.
murchandamus approved
murchandamus commented at 5:37 pm on May 31, 2024: contributor

BIP champion approved this change, and it seems like an improvement to me. Any reservations on merging this, @luke-jr?
murchandamus removed the label Pending acceptance on May 31, 2024
luke-jr commented at 5:46 pm on May 31, 2024: member

Sounds fine to me (though I didn’t verify the crypto)

This test vector is also included in ongoing implementation of BIP322(PR is closed but seems like still in development here)

This was a branch I made for OCEAN to be compatible with BIP322 signatures. It isn’t intended as further development of BIP322 nor support thereof for Core or Knots.

I did consider developing BIP322 further, but came to the conclusion I would need to break compatibility with the current draft, and unfortunately the current draft is already implemented.

IMO at this stage, it should be stripped down to the one case actually implemented (afaik just Simple) and marked Final (if someone wants to complete a new signature system that actually covers all the use cases correctly, it should be a new BIP).
luke-jr merged this on May 31, 2024
luke-jr closed this on May 31, 2024

Contributors
ChrisCho-H murchandamus kallewoof luke-jr

Labels
Proposed BIP modification