Fix typos on 17 files. #1602

pull Sajjon wants to merge 1 commits into bitcoin:master from Sajjon:cyon_fix_typos changing 17 files +29 −29
  1. Sajjon commented at 5:26 pm on May 28, 2024: contributor
    Fix typos in 17 files
  2. Fix typos on 17 files. 1eefea0456
  3. in bip-0158/gentestvectors.go:40 in 1eefea0456
    36@@ -37,7 +37,7 @@ var (
    37 		{49291, "Tx pays to empty output script"},
    38 		{180480, "Tx spends from empty output script"},
    39 		{926485, "Duplicate pushdata 913bcc2be49cb534c20474c4dee1e9c4c317e7eb"},
    40-		{987876, "Coinbase tx has unparseable output script"},
    41+		{987876, "Coinbase tx has unparsable output script"},
    


    vostrnad commented at 5:34 pm on May 28, 2024:
    “unparseable” is not a typo but a valid alternative spelling.

    Sajjon commented at 7:04 pm on May 28, 2024:
    Indeed, so somewhat false positive, let me know if I should revert.
  4. vostrnad approved
  5. vostrnad commented at 5:34 pm on May 28, 2024: contributor
    ACK mod one false positive.
  6. murchandamus approved
  7. murchandamus commented at 5:37 pm on May 28, 2024: contributor

    LGTM, although for “queriable/queryable” and “unparseable/unparsable” in each case both seem acceptable, so maybe drop those changes.

    ACK 1eefea0456d661b4c51f3a40b7262d6a99161edd

  8. jonatack commented at 3:04 am on May 29, 2024: contributor

    ACK 1eefea0456d661b4c51f3a40b7262d6a99161edd

    Edit: I agree that queriable/queryable and unparseable/unparsable are both fine and didn’t need to be changed, but it doesn’t really matter.

  9. jonatack merged this on May 29, 2024
  10. jonatack closed this on May 29, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 16:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me