BIP39: fix grammar in wordlists doc #1626
pull nnsW3 wants to merge 16 commits into bitcoin:master from nnsW3:Docs-improvements changing 1 files +3 −3-
nnsW3 commented at 4:28 pm on June 25, 2024: contributorRectify typographical inaccuracies.
-
improvements assignments.mediawiki a586a43001
-
fix assignments.mediawiki 1c08f6d18f
-
fix bip-0039-wordlists.md 8ee522c39e
-
fix bip-0001.mediawiki 4a4637f07f
-
fix bip-0002.mediawiki 1f4fbb2996
-
fix bip-0009.mediawiki 8047debc3b
-
fix bip-0010.mediawiki 0f5ad285f4
-
fix bip-0011.mediawiki f2d76ae121
-
in bip-0001.mediawiki:33 in f2d76ae121 outdated
29@@ -30,7 +30,7 @@ There are three kinds of BIP: 30 31 The BIP process begins with a new idea for Bitcoin. Each potential BIP must have a champion -- someone who writes the BIP using the style and format described below, shepherds the discussions in the appropriate forums, and attempts to build community consensus around the idea. The BIP champion (a.k.a. Author) should first attempt to ascertain whether the idea is BIP-able. Posting to the [https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev bitcoin-dev@lists.linuxfoundation.org] mailing list (and maybe the [https://bitcointalk.org/index.php?board=6.0 Development & Technical Discussion] forum) is the best way to go about this. 32 33-Vetting an idea publicly before going as far as writing a BIP is meant to save both the potential author and the wider community time. Many ideas have been brought forward for changing Bitcoin that have been rejected for various reasons. Asking the Bitcoin community first if an idea is original helps prevent too much time being spent on something that is guaranteed to be rejected based on prior discussions (searching the internet does not always do the trick). It also helps to make sure the idea is applicable to the entire community and not just the author. Just because an idea sounds good to the author does not mean it will work for most people in most areas where Bitcoin is used. Small enhancements or patches often don't need standardisation between multiple projects; these don't need a BIP and should be injected into the relevant Bitcoin development work flow with a patch submission to the applicable Bitcoin issue tracker. 34+Vetting an idea publicly before going as far as writing a BIP is meant to save both the potential author and the wider community time. Many ideas have been brought forward for changing Bitcoin that have been rejected for various reasons. Asking the Bitcoin community first if an idea is original helps prevent too much time being spent on something that is guaranteed to be rejected based on prior discussions (searching the internet does not always do the trick). It also helps to make sure the idea is applicable to the entire community and not just the author. Just because an idea sounds good to the author does not mean it will work for most people in most areas where Bitcoin is used. Small enhancements or patches often don't need standardization between multiple projects; these don't need a BIP and should be injected into the relevant Bitcoin development work flow with a patch submission to the applicable Bitcoin issue tracker.
jonatack commented at 4:35 pm on June 25, 2024:It’s unnecessary to change from UK to US spelling.in bip-0039/bip-0039-wordlists.md:31 in f2d76ae121 outdated
27@@ -28,7 +28,7 @@ for two smaller words (This would be a problem with any of the 3 character sets 28 29 ### Spanish 30 31-1. Words can be uniquely determined typing the first 4 characters (sometimes less). 32+1. Words can be uniquely determined by typing the first 4 characters (sometimes less).
jonatack commented at 4:45 pm on June 25, 2024:At first glance, this is the only change in this pull that I’d potentially support, but there are two other instances of the same in this file. Seems best to change all of them or none.jonatack commented at 4:46 pm on June 25, 2024: contributorNot sure if it’s worth changing BIPs that are final or withdrawn.Update bip-0039-wordlists.md fc5a610e34nnsW3 commented at 4:51 pm on June 25, 2024: contributorDo you want me to let the other as they were?jonatack commented at 5:10 pm on June 25, 2024: contributorDo you want me to let the other as they were?
Yes, suggest keeping only the changes in the wordlist file.
Update bip-0001.mediawiki bc4da04f2dUpdate bip-0002.mediawiki 1415e49703Update assignments.mediawiki 09b1b7e558Update bip-0009.mediawiki 9eb3f856d9Update assignments.mediawiki fd4c49b0ddUpdate bip-0010.mediawiki 57b8645c7fUpdate bip-0011.mediawiki 06e48416bcnnsW3 commented at 5:24 pm on June 25, 2024: contributordone sirjonatack renamed this:
Docs improvements
BIP39: fix grammar in wordlists doc
on Jun 25, 2024jonatack commented at 5:25 pm on June 25, 2024: contributorACKjonatack merged this on Jun 25, 2024jonatack closed this on Jun 25, 2024
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-09 07:10 UTC
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-09 07:10 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me