WIP:bip-0379.mediawiki:formatting #1628

pull RandyMcMillan wants to merge 1 commits into bitcoin:master from bitcoincore-dev:2023/849749/491038/4d901a4/fdcc12c-bip-0379.mediawiki changing 2 files +26 −24
  1. RandyMcMillan commented at 0:08 am on June 28, 2024: contributor
  2. achow101 commented at 0:12 am on June 28, 2024: member

    NACK

    The tables are messed up and harder to maintain in mediawiki, and that is why markdown was explicitly chosen.

  3. bip-0379.mediawiki:formatting 1f1d09cea6
  4. jonatack commented at 0:13 am on June 28, 2024: contributor
    Hi @RandyMcMillan, markdown files are an acceptable format for BIPs (see https://github.com/bitcoin/bips/blob/master/bip-0002.mediawiki#bip-format-and-structure). There’s no need to convert it to mediawiki.
  5. RandyMcMillan force-pushed on Jun 28, 2024
  6. jonatack commented at 0:15 am on June 28, 2024: contributor
    Thanks for your proposal; closing per BIP author NACK.
  7. jonatack closed this on Jun 28, 2024

  8. jonatack commented at 0:18 am on June 28, 2024: contributor

    @RandyMcMillan I would suggest a PR with the following fixup, if you’d like to do that (or an equivalent):

    0--- a/bip-0379.md
    1+++ b/bip-0379.md
    2@@ -411,7 +411,7 @@ descriptors and produce the same scripts.
    3 ## Reference Implementation
    4 
    5 A first reference implementation and documentation for Miniscript in P2WSH was originally published at
    6-https://github.com/sipa/miniscript .
    7+[https://github.com/sipa/miniscript](https://github.com/sipa/miniscript).
    
  9. RandyMcMillan commented at 0:19 am on June 28, 2024: contributor

    @achow101 @jonatack @murchandamus

    Posting this for when you realize that they aren’t that difficult to maintain and that downstream rendering will break.

    sample rendering:

  10. achow101 commented at 0:49 am on June 28, 2024: member

    Posting this for when you realize that they aren’t that difficult to maintain.

    Considering that GitHub does not even render your branch correctly at all, I would beg to disagree.

    Also, I did in fact write this in mediawiki originally and know firsthand how difficult it is to maintain.

    downstream rendering will break.

    As this repo is the ground truth for BIPs, and afaik, is not intended to be be consumed by downstream, that does not seem like something that bip authors should be considering.

  11. RandyMcMillan renamed this:
    bip-0379.mediawiki:formatting
    WIP:bip-0379.mediawiki:formatting
    on Jun 28, 2024
  12. RandyMcMillan commented at 11:46 pm on June 28, 2024: contributor

    wikimedia formatting is an improvement:


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 09:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me