BIP-0386: Fix uncompressed private key test vector #1631

pull azuchi wants to merge 1 commits into bitcoin:master from azuchi:fix-bip386-test-vector changing 1 files +1 −1
  1. azuchi commented at 12:55 pm on July 6, 2024: contributor

    Base58 in the WIF format is case sensitive. The following Test Vector will result in an error indicating the WIF version is invalid, regardless of the compression state of the public key.

    05kyzdueo39z3fprtux2qbbwgnnp5ztd7yyr2sc1j299sbcnwjss
    

    The following is probably what was intended:

    05KYZdUEo39z3FPrtuX2QbbwGnNP5zTd7yyr2SC1j299sBCnWjss
    
  2. BIP-0386: Fix uncompressed private key test vector 7acfe207e0
  3. murchandamus requested review from sipa on Jul 8, 2024
  4. murchandamus requested review from achow101 on Jul 8, 2024
  5. murchandamus assigned murchandamus on Jul 8, 2024
  6. murchandamus unassigned murchandamus on Jul 8, 2024
  7. murchandamus added the label Proposed BIP modification on Jul 8, 2024
  8. murchandamus added the label Pending acceptance on Jul 8, 2024
  9. 525411 approved
  10. in bip-0386.mediawiki:104 in 7acfe207e0
    100@@ -101,7 +101,7 @@ Valid descriptors followed by the scripts they produce. Descriptors involving de
    101 
    102 Invalid Descriptors
    103 
    104-* Uncompressed private key: <tt>tr(5kyzdueo39z3fprtux2qbbwgnnp5ztd7yyr2sc1j299sbcnwjss)</tt>
    105+* Uncompressed private key: <tt>tr(5KYZdUEo39z3FPrtuX2QbbwGnNP5zTd7yyr2SC1j299sBCnWjss)</tt>
    


    jonatack commented at 7:06 pm on July 24, 2024:

    Change LGTM

    before

    0$ ./src/bitcoin-cli getdescriptorinfo "tr(5kyzdueo39z3fprtux2qbbwgnnp5ztd7yyr2sc1j299sbcnwjss)"             
    1error code: -5
    2error message:
    3tr(): key '5kyzdueo39z3fprtux2qbbwgnnp5ztd7yyr2sc1j299sbcnwjss' is not valid
    

    after

    0$ ./src/bitcoin-cli getdescriptorinfo "tr(5KYZdUEo39z3FPrtuX2QbbwGnNP5zTd7yyr2SC1j299sBCnWjss)"
    1error code: -5
    2error message:
    3tr(): Uncompressed keys are not allowed
    

    and with this change, returns the same error as the example on the following line (105)

    0$ ./src/bitcoin-cli getdescriptorinfo "tr(04a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd5b8dec5235a0fa8722476c7709c02559e3aa73aa03918ba2d492eea75abea235)"
    1error code: -5
    2error message:
    3tr(): Uncompressed keys are not allowed
    
  11. KamPuc86zg commented at 2:17 am on July 25, 2024: none
    /usr/bin/git config –global –add safe.directory /home/runner/work/bips/bips
  12. jonatack commented at 2:09 pm on July 26, 2024: member
    cc @achow101 for feedback
  13. jonatack removed the label Proposed BIP modification on Jul 27, 2024
  14. jonatack added the label Bug fix on Jul 27, 2024
  15. bitcoin deleted a comment on Aug 11, 2024
  16. achow101 commented at 4:05 pm on August 14, 2024: member
    ACK 7acfe207e0e78ee6fc6053789cc90ac848dcfeb2
  17. jonatack removed the label Pending acceptance on Aug 14, 2024
  18. jonatack commented at 4:43 pm on August 14, 2024: member
    Thank you @azuchi @achow101
  19. jonatack merged this on Aug 14, 2024
  20. jonatack closed this on Aug 14, 2024

  21. bitcoin deleted a comment on Aug 23, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-09 07:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me